Mac HW Video Decode: Fix texture creation

Mac HW Video Decode: Fix texture creation

The Mac hardware video decoder code was failing to create textures.

The problem was that RendererGpuVideoDecoderFactories::AsyncCreateTextures() was calling glTextImage2D. This didn't work for GL_TEXTURE_RECTANGLE_ARB textures.

BUG=127414
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146631

[Ami GONE FROM CHROMIUM, 2012-07-13 17:24:21]

lgtm

https://chromiumcodereview.appspot.com/10703184/diff/1/content/renderer/media...
File content/renderer/media/renderer_gpu_video_decoder_factories.cc (right):

https://chromiumcodereview.appspot.com/10703184/diff/1/content/renderer/media...
content/renderer/media/renderer_gpu_video_decoder_factories.cc:115: if
(texture_target != GL_TEXTURE_RECTANGLE_ARB) {
Should this instead be == _2D?

[sail, 2012-07-13 17:30:51]

https://chromiumcodereview.appspot.com/10703184/diff/1/content/renderer/media...
File content/renderer/media/renderer_gpu_video_decoder_factories.cc (right):

https://chromiumcodereview.appspot.com/10703184/diff/1/content/renderer/media...
content/renderer/media/renderer_gpu_video_decoder_factories.cc:115: if
(texture_target != GL_TEXTURE_RECTANGLE_ARB) {
On 2012/07/13 17:24:21, Ami Fischman wrote:
> Should this instead be == _2D?

It has to be RECTANGLE_ARB since we _2D works fine.

[Ami GONE FROM CHROMIUM, 2012-07-13 17:34:14]

https://chromiumcodereview.appspot.com/10703184/diff/1/content/renderer/media...
File content/renderer/media/renderer_gpu_video_decoder_factories.cc (right):

https://chromiumcodereview.appspot.com/10703184/diff/1/content/renderer/media...
content/renderer/media/renderer_gpu_video_decoder_factories.cc:115: if
(texture_target != GL_TEXTURE_RECTANGLE_ARB) {
On 2012/07/13 17:30:51, sail wrote:
> On 2012/07/13 17:24:21, Ami Fischman wrote:
> > Should this instead be == _2D?
> 
> It has to be RECTANGLE_ARB since we _2D works fine.

I mean that instead of conditionalizing the TexImage2D call on *not* being ARB,
conditionalize it on *being* 2D.

[sail, 2012-07-13 17:59:34]

https://chromiumcodereview.appspot.com/10703184/diff/1/content/renderer/media...
File content/renderer/media/renderer_gpu_video_decoder_factories.cc (right):

https://chromiumcodereview.appspot.com/10703184/diff/1/content/renderer/media...
content/renderer/media/renderer_gpu_video_decoder_factories.cc:115: if
(texture_target != GL_TEXTURE_RECTANGLE_ARB) {
On 2012/07/13 17:34:14, Ami Fischman wrote:
> On 2012/07/13 17:30:51, sail wrote:
> > On 2012/07/13 17:24:21, Ami Fischman wrote:
> > > Should this instead be == _2D?
> > 
> > It has to be RECTANGLE_ARB since we _2D works fine.
> 
> I mean that instead of conditionalizing the TexImage2D call on *not* being
ARB,
> conditionalize it on *being* 2D.

Oops, sorry. Fixed.

[commit-bot: I haz the power, 2012-07-13 18:27:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10703184/6001

[commit-bot: I haz the power, 2012-07-13 20:08:20]

Change committed as 146631