Migrate drag&drop code in test_shell to new WebKit API

Migrate drag&drop code in test_shell to new WebKit API

In http://webkit.org/b/90996 , I tried to remove the old API, but
some code in test_shell Win was still using the old API.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146381

[ojan, 2012-07-12 17:10:16]

LGTM


On Thu, Jul 12, 2012 at 10:08 AM, <tony@chromium.org> wrote:

> Reviewers: ojan, abarth,
>
> Description:
> Migrate drag&drop code in test_shell to new WebKit API
>
> In http://webkit.org/b/90996 , I tried to remove the old API, but
> some code in test_shell Win was still using the old API.
>
> BUG=None
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10703171/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M webkit/tools/test_shell/drop_**delegate.cc
>
>
> Index: webkit/tools/test_shell/drop_**delegate.cc
> diff --git a/webkit/tools/test_shell/**drop_delegate.cc
> b/webkit/tools/test_shell/**drop_delegate.cc
> index 4f577043536efe98ac10487fb77c07**2d01ba3842..**
> aff7116e7a37f40e704dbe926c295c**dd8a64d9df 100644
> --- a/webkit/tools/test_shell/**drop_delegate.cc
> +++ b/webkit/tools/test_shell/**drop_delegate.cc
> @@ -32,7 +32,8 @@ DWORD TestDropDelegate::OnDragEnter(**IDataObject*
> data_object,
>        drop_data.ToDragData(),
>        WebPoint(client_pt.x, client_pt.y),
>        WebPoint(cursor_position.x, cursor_position.y),
> -      WebDragOperationCopy);
> +      WebDragOperationCopy,
> +      0);
>    // TODO(snej): Pass the real drag operation instead
>    return op ? DROPEFFECT_COPY : DROPEFFECT_NONE;
>    // TODO(snej): Return the real drop effect constant matching 'op'
> @@ -47,7 +48,8 @@ DWORD TestDropDelegate::OnDragOver(**IDataObject*
> data_object,
>    WebDragOperation op = webview_->dragTargetDragOver(
>        WebPoint(client_pt.x, client_pt.y),
>        WebPoint(cursor_position.x, cursor_position.y),
> -      WebDragOperationCopy);
> +      WebDragOperationCopy,
> +      0);
>    // TODO(snej): Pass the real drag operation instead
>    return op ? DROPEFFECT_COPY : DROPEFFECT_NONE;
>    // TODO(snej): Return the real drop effect constant matching 'op'
> @@ -65,7 +67,8 @@ DWORD TestDropDelegate::OnDrop(**IDataObject*
> data_object,
>    ScreenToClient(GetHWND(), &client_pt);
>    webview_->dragTargetDrop(
>        WebPoint(client_pt.x, client_pt.y),
> -      WebPoint(cursor_position.x, cursor_position.y));
> +      WebPoint(cursor_position.x, cursor_position.y),
> +      0);
>
>    // webkit win port always returns DROPEFFECT_NONE
>    return DROPEFFECT_NONE;
>
>
>