Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: chromeos/dbus/cryptohome_client.h

Issue 10703162: chromeos: Remove CryptohomeLibrary::TpmGetPassword and TpmIsReady (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More localized variables Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chromeos/dbus/cryptohome_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/cryptohome_client.h
diff --git a/chromeos/dbus/cryptohome_client.h b/chromeos/dbus/cryptohome_client.h
index af32c80918adec16f979706e4cbbcd2338913241..2d619dab151279de99ed9f230eb88200eee5e8dc 100644
--- a/chromeos/dbus/cryptohome_client.h
+++ b/chromeos/dbus/cryptohome_client.h
@@ -33,6 +33,9 @@ class CHROMEOS_EXPORT CryptohomeClient {
// A callback to handle responses of methods returning a bool value.
typedef base::Callback<void(DBusMethodCallStatus call_status,
bool result)> BoolMethodCallback;
+ // A callback to handle responses of methods returning a string value.
+ typedef base::Callback<void(DBusMethodCallStatus call_status,
+ const std::string& result)> StringMethodCallback;
// A callback to handle responses of Pkcs11GetTpmTokenInfo method.
typedef base::Callback<void(
DBusMethodCallStatus call_status,
@@ -97,9 +100,8 @@ class CHROMEOS_EXPORT CryptohomeClient {
// succeeds.
virtual void AsyncMountGuest(const AsyncMethodCallback& callback) = 0;
- // Calls TpmIsReady method and returns true when the call succeeds.
- // This method blocks until the call returns.
- virtual bool TpmIsReady(bool* ready) = 0;
+ // Calls TpmIsReady method.
+ virtual void TpmIsReady(const BoolMethodCallback& callback) = 0;
// Calls TpmIsEnabled method.
virtual void TpmIsEnabled(const BoolMethodCallback& callback) = 0;
@@ -109,10 +111,8 @@ class CHROMEOS_EXPORT CryptohomeClient {
// TODO(hashimoto): Remove this method. crosbug.com/28500
virtual bool CallTpmIsEnabledAndBlock(bool* enabled) = 0;
- // Calls TpmGetPassword method and returns true when the call succeeds.
- // This method blocks until the call returns.
- // The original content of |password| is lost.
- virtual bool TpmGetPassword(std::string* password) = 0;
+ // Calls TpmGetPassword method.
+ virtual void TpmGetPassword(const StringMethodCallback& callback) = 0;
// Calls TpmIsOwned method and returns true when the call succeeds.
// This method blocks until the call returns.
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chromeos/dbus/cryptohome_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698