Issue 10703159: Fix MessageReader to handle errors properly.

Issue 10703159: Fix MessageReader to handle errors properly. (Closed)

Created:
8 years, 5 months ago by Sergey Ulanov

Modified:
8 years, 5 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix MessageReader to handle errors properly. BUG=136935 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146719

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -9 lines)			Patch
M	remoting/protocol/fake_session.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	remoting/protocol/fake_session.cc	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
M	remoting/protocol/message_reader.cc	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
M	remoting/protocol/message_reader_unittest.cc	View	1	4 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM but I notice that UseSocketOnCorrectThread mixed declaration of expectations with code that triggers them, ...

8 years, 5 months ago (2012-07-14 00:58:34 UTC) #3

Sergey Ulanov

> LGTM but I notice that UseSocketOnCorrectThread mixed declaration of > expectations with code that ...

8 years, 5 months ago (2012-07-14 01:17:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10703159/7001

8 years, 5 months ago (2012-07-14 01:24:55 UTC) #5

Change committed as 146719

Expand Messages | Collapse Messages