Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10703158: Change ActiveTabTest to do setup in SetUp rather than its constructor. (Closed)

Created:
8 years, 5 months ago by Matt Perry
Modified:
8 years, 5 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Change ActiveTabTest to do setup in SetUp rather than its constructor. BUG=136629 TEST= TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146279

Patch Set 1 #

Patch Set 2 : SetUp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/extensions/active_tab_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Matt Perry
8 years, 5 months ago (2012-07-12 01:19:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10703158/6001
8 years, 5 months ago (2012-07-12 01:25:16 UTC) #2
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 03:09:59 UTC) #3 
Change committed as 146279

Powered by Google App Engine
This is Rietveld 408576698