Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 10703156: Merge 146217 - Convert SID string to ASCII before taking md5 (Closed)

Created:
8 years, 5 months ago by gab
Modified:
8 years, 5 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Merge 146217 - Convert SID string to ASCII before taking md5 (otherwise only half (the common half...:( ) of the sid string would get encoded...) this change is super trivial and only fixes the resulting suffix R=grt@chromium.org BUG=133810 TEST=Make sure Chrome gets the proper suffix Review URL: https://chromiumcodereview.appspot.com/10703147 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/installer/util/shell_util.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
gab
8 years, 5 months ago (2012-07-12 00:02:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698