Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 10703155: Merge 145596 - Use a better registration suffix that will always be unique while respecting the MSD… (Closed)

Created:
8 years, 5 months ago by gab
Modified:
8 years, 5 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Merge 145596 - Use a better registration suffix that will always be unique while respecting the MSDN rules (2nd try). The suffix will now be the base32 encoding of the md5 hash of the user's SID. This is always unique and can be determined many times deterministically without I/O access (as opposed to other methods we considered). It respects all MSDN constraints for properties onto which it is appended. This replaces the prior-style username suffixes for new installs. Old-style suffixes (i.e. unsuffixed and username suffixed) will however be kept as is through future updates. Design doc: https://docs.google.com/a/chromium.org/document/d/1qmcV3uYBh3JwvXhYkI7asg0nN7KfVMWVOzND4p0jQ3E/edit Note: This is the continuation of http://codereview.chromium.org/10617002/ which was reverted in https://chromiumcodereview.appspot.com/10667006/ BUG=133810, 133173 TEST= http://goo.gl/ZZ7gE installer_util_unittests.exe --gtest_filter=ShellUtilTest.* Review URL: https://chromiumcodereview.appspot.com/10662052 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -56 lines) Patch
M chrome/installer/setup/uninstall.cc View 2 chunks +14 lines, -9 lines 0 comments Download
M chrome/installer/util/shell_util.h View 2 chunks +32 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 12 chunks +193 lines, -38 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 8 chunks +44 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
gab
8 years, 5 months ago (2012-07-12 00:00:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698