Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: vm/os.h

Issue 10703150: Don't create a Bigint object first for every integer while parsing the sources, instead first check… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/os.h
===================================================================
--- vm/os.h (revision 9558)
+++ vm/os.h (working copy)
@@ -82,6 +82,13 @@
const char* format,
va_list args);
+ // Converts a C string to a 64 bit value.
+ // Returns false if it is unable to convert the string to a 64 bit value,
+ // the failure could be because of underflow/overflow or invalid characters.
+ // On success the function returns true and 'value' contains the converted
+ // value.
sra1 2012/07/11 21:46:43 Please document the valid inputs. E.g., one might
siva 2012/07/12 18:28:23 I have renamed it as 'StringToInteger' to avoid an
+ static bool Strtoll(const char* str, int64_t* value);
+
// Initialize the OS class.
static void InitOnce();

Powered by Google App Engine
This is Rietveld 408576698