Don't create a Bigint object first for every integer while parsing the sources, instead first check…

vm/os.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OS_H_
 #define VM_OS_H_
 
 #include "vm/globals.h"
 
 // Forward declarations.
@@ skipping 64 matching lines @@
   //
   // This specification conforms to C99 standard which is implemented
   // by glibc 2.1+ with one exception: the C99 standard allows a
   // negative return value.  We will terminate the vm rather than let
   // that occur.
   static int SNPrint(char* str, size_t size, const char* format, ...);
   static int VSNPrint(char* str, size_t size,
                       const char* format,
                       va_list args);
 
+  // Converts a C string to a 64 bit value.
+  // Returns false if it is unable to convert the string to a 64 bit value,
+  // the failure could be because of underflow/overflow or invalid characters.
+  // On success the function returns true and 'value' contains the converted
+  // value.

[sra1, 2012/07/11 21:46:43]

Please document the valid inputs. E.g., one might say that the input must be a
valid Dart integer number literal.

This function has many differences to what you might expect from the name
'Strtoll'.  No leading whitespace. No automatic detection of octal radix.  None
of the implementations correctly detect trailing crap.  '123X' will be converted
to 123, and 'QQ', '' and '-' will be converted to 0.

This is all OK if documented, otherwise the code should work properly for any
input.

[siva, 2012/07/12 18:28:23]

I have renamed it as 'StringToInteger' to avoid any confusion and expectations
of how this function should work.

On 2012/07/11 21:46:43, sra1 wrote:

+  static bool Strtoll(const char* str, int64_t* value);
+
   // Initialize the OS class.
   static void InitOnce();
 
   // Shut down the OS class.
   static void Shutdown();
 
   static void Abort();
 
   static void Exit(int code);
 };
 
 }  // namespace dart
 
 #endif  // VM_OS_H_