Don't create a Bigint object first for every integer while parsing the sources, instead first check…

vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 7661 matching lines @@
 
 
 const char* Integer::ToCString() const {
   // Integer is an interface. No instances of Integer should exist.
   UNREACHABLE();
   return "Integer";
 }
 
 
 RawInteger* Integer::New(const String& str, Heap::Space space) {
-  // TODO(iposva): If returning a big integer it will not necessarily be in the
-  // requested space.
-  const Bigint& big = Bigint::Handle(Bigint::New(str));
-  if (BigintOperations::FitsIntoSmi(big)) {
-    return BigintOperations::ToSmi(big);
-  } else if (BigintOperations::FitsIntoMint(big)) {
-    return Mint::New(BigintOperations::ToMint(big), space);
+  if (str.IsOneByteString()) {
+    const OneByteString& onestr = OneByteString::Cast(str);
+    int64_t value;
+    if (!OS::Strtoll(onestr.ToCString(), &value)) {
+      const Bigint& big = Bigint::Handle(Bigint::New(onestr, space));
+      ASSERT(!BigintOperations::FitsIntoSmi(big));
+      ASSERT(!BigintOperations::FitsIntoMint(big));
+      return big.raw();
+    }
+    return Integer::New(value, space);
   } else {
-    return big.raw();
+    // We are not supposed to have integers represented as two byte or

[cshapiro, 2012/07/11 22:11:02]

Why isn't this just an ASSERT(str.IsOneByteString()) at the top?

[siva, 2012/07/12 18:28:23]

Done.

+    // four byte strings.
+    UNREACHABLE();
+    return Integer::null();
   }
 }
 
 
 RawInteger* Integer::New(int64_t value, Heap::Space space) {
   if ((value <= Smi::kMaxValue) && (value >= Smi::kMinValue)) {
     return Smi::New(value);
   }
   return Mint::New(value, space);
 }
@@ skipping 2951 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart