Issue 10703147: Convert SID string to ASCII before taking md5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10703147: Convert SID string to ASCII before taking md5 (Closed)

Created:
8 years, 5 months ago by gab

Modified:
8 years, 5 months ago

Reviewers:
grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org, chrome-win8-eng_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert SID string to ASCII before taking md5 (otherwise only half (the common half...:( ) of the sid string would get encoded...) this change is super trivial and only fixes the resulting suffix R=grt@chromium.org BUG=133810 TEST=Make sure Chrome gets the proper suffix Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146217

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/installer/util/shell_util.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10703147/1

8 years, 5 months ago (2012-07-11 20:28:11 UTC) #3

Change committed as 146217

Expand Messages | Collapse Messages