Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 10703146: PPAPI: Add console logging methods to pp::InstancePrivate. (Closed)

Created:
8 years, 5 months ago by viettrungluu
Modified:
8 years, 5 months ago
Reviewers:
brettw, yzshen1
CC:
chromium-reviews
Visibility:
Public.

Description

PPAPI: Add console logging methods to pp::InstancePrivate. We didn't want to add them to pp::Instance (since they're not available to NaCl plugins?), so add them to InstancePrivate. (We can move them to Instance later, if desired.) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146456

Patch Set 1 #

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M ppapi/cpp/private/instance_private.h View 1 3 chunks +16 lines, -1 line 0 comments Download
M ppapi/cpp/private/instance_private.cc View 1 3 chunks +25 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
Only one of {brettw,yzshen} needed; I just don't know who's around.
8 years, 5 months ago (2012-07-11 20:14:28 UTC) #1
viettrungluu
http://en.wikipedia.org/wiki/Diffusion_of_responsibility
8 years, 5 months ago (2012-07-12 17:27:41 UTC) #2
yzshen1
lgtm
8 years, 5 months ago (2012-07-12 17:45:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/10703146/2002
8 years, 5 months ago (2012-07-12 19:36:30 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 22:03:19 UTC) #5
Change committed as 146456

Powered by Google App Engine
This is Rietveld 408576698