[MIPS] Toolchain scripts for MIPS architecture.

[MIPS] Toolchain scripts for MIPS architecture.

    Scripts that download, build and prepare tools for MIPS architecture.
    The current set is dependent on QEMU 0.12.5.

    There is no stock crosstoolchain for MIPS on Ubuntu, so we download Mentor's
    crosstoolchain. The other libraries come from standard Debian distribution
    (Squeeze) for MIPS, yet are tested on Ubuntu Lucid.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2275
TEST=tools/llvm/trusted-toolchain-creator-mips.sh trusted_sdk

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=9402

[petarj, 2012-07-11 17:34:40]

Here is a change with scripts that download, build and prepare tools for MIPS
architecture. The current set is dependent on QEMU 0.12.5 and the change
includes a patch for it.
We do plan to switch to 1.X QEMU later.

[Robert Muth (chromium), 2012-07-11 18:41:23]

Few questions/comments:

our qemu patch for arm only adds an optional tracing functionality
so we could also use the stock qemu which on ubuntu is 
qemu-arm provided by qemu-user

Does qemu-mips provided by the  same package work for you if not 
explain in the description what your patch does.
BTW: out patches live in: ../third_party/qemu/

You toolchain seems to come form debian -- any chance we could standardize this
on ubuntu, this way the arm and mips scripts would look more similar - in any
case can you change
the name of  "trusted-toolchain-creator-mips.sh" to reflect
the "release" - it seems like you are tied to karmic.
Please also mention this in the description and briefly say why you
could not use precise which it a LTS release hence preferable.

I will change our scripts to also reflect both the arch and the release.
 



On 2012/07/11 17:34:40, petarj wrote:
> Here is a change with scripts that download, build and prepare tools for MIPS
> architecture. The current set is dependent on QEMU 0.12.5 and the change
> includes a patch for it.
> We do plan to switch to 1.X QEMU later.

[robertm, 2012-07-11 18:52:22]

One more thinh:

the arm trusted TC was also used to build chrome 
(at least that worked around xmas time last year)
what TC do you use right now to build chrome?
would it make sense to add chrome building functionality to
tools/llvm/trusted-toolchain-creator-mips.sh


On 2012/07/11 18:41:23, Robert Muth (chromium) wrote:
> Few questions/comments:
> 
> our qemu patch for arm only adds an optional tracing functionality
> so we could also use the stock qemu which on ubuntu is 
> qemu-arm provided by qemu-user
> 
> Does qemu-mips provided by the  same package work for you if not 
> explain in the description what your patch does.
> BTW: out patches live in: ../third_party/qemu/
> 
> You toolchain seems to come form debian -- any chance we could standardize
this
> on ubuntu, this way the arm and mips scripts would look more similar - in any
> case can you change
> the name of  "trusted-toolchain-creator-mips.sh" to reflect
> the "release" - it seems like you are tied to karmic.
> Please also mention this in the description and briefly say why you
> could not use precise which it a LTS release hence preferable.
> 
> I will change our scripts to also reflect both the arch and the release.
>  
> 
> 
> 
> On 2012/07/11 17:34:40, petarj wrote:
> > Here is a change with scripts that download, build and prepare tools for
MIPS
> > architecture. The current set is dependent on QEMU 0.12.5 and the change
> > includes a patch for it.
> > We do plan to switch to 1.X QEMU later.

[petarj, 2012-07-13 17:52:08]

There are no stock crosstoolchain for MIPS on Ubuntu, so we download Mentor's
crosstoolchain. The other libraries come from standard Debian distribution for
MIPS.

Dillema here: should the script be renamed to
trusted-toolchain-creator.mipsel.squeeze.sh or
trusted-toolchain-creator.mipsel.lucid.sh? (the packages have been pulled from
Debian Squeeze yet tested on Ubuntu Lucid)

As of building Chromium, we use the same toolchain and very similar script (it
requries more libraries to build Chromium). Should we place that script instead
of this one?

On 2012/07/11 18:52:22, robertm wrote:
> One more thinh:
> 
> the arm trusted TC was also used to build chrome 
> (at least that worked around xmas time last year)
> what TC do you use right now to build chrome?
> would it make sense to add chrome building functionality to
> tools/llvm/trusted-toolchain-creator-mips.sh
> 
> 
> On 2012/07/11 18:41:23, Robert Muth (chromium) wrote:
> > Few questions/comments:
> > 
> > our qemu patch for arm only adds an optional tracing functionality
> > so we could also use the stock qemu which on ubuntu is 
> > qemu-arm provided by qemu-user
> > 
> > Does qemu-mips provided by the  same package work for you if not 
> > explain in the description what your patch does.
> > BTW: out patches live in: ../third_party/qemu/
> > 
> > You toolchain seems to come form debian -- any chance we could standardize
> this
> > on ubuntu, this way the arm and mips scripts would look more similar - in
any
> > case can you change
> > the name of  "trusted-toolchain-creator-mips.sh" to reflect
> > the "release" - it seems like you are tied to karmic.
> > Please also mention this in the description and briefly say why you
> > could not use precise which it a LTS release hence preferable.
> > 
> > I will change our scripts to also reflect both the arch and the release.
> >  
> > 
> > 
> > 
> > On 2012/07/11 17:34:40, petarj wrote:
> > > Here is a change with scripts that download, build and prepare tools for
> MIPS
> > > architecture. The current set is dependent on QEMU 0.12.5 and the change
> > > includes a patch for it.
> > > We do plan to switch to 1.X QEMU later.

[robertm, 2012-07-13 18:16:17]

On Fri, Jul 13, 2012 at 1:52 PM, <petarj@mips.com> wrote:

> There are no stock crosstoolchain for MIPS on Ubuntu, so we download
> Mentor's
> crosstoolchain. The other libraries come from standard Debian distribution
> for
> MIPS.
>


Please add this information to the CL description.

>
> Dillema here: should the script be renamed to
>
trusted-toolchain-creator.**mipsel.squeeze.sh<http://trusted-toolchain-creator.mipsel.squeeze.sh>or
>
trusted-toolchain-creator.**mipsel.lucid.sh<http://trusted-toolchain-creator.mipsel.lucid.sh>?
> (the packages have been pulled from
> Debian Squeeze yet tested on Ubuntu Lucid)
>

Either one is fine but also mention this in the bug description.



> As of building Chromium, we use the same toolchain and very similar script
> (it
> requries more libraries to build Chromium). Should we place that script
> instead
> of this one?
>
>
> On 2012/07/11 18:52:22, robertm wrote:
>
>> One more thinh:
>>
>
>  the arm trusted TC was also used to build chrome
>> (at least that worked around xmas time last year)
>> what TC do you use right now to build chrome?
>> would it make sense to add chrome building functionality to
>> tools/llvm/trusted-toolchain-**creator-mips.sh
>>
>
>
>  On 2012/07/11 18:41:23, Robert Muth (chromium) wrote:
>> > Few questions/comments:
>> >
>> > our qemu patch for arm only adds an optional tracing functionality
>> > so we could also use the stock qemu which on ubuntu is
>> > qemu-arm provided by qemu-user
>> >
>> > Does qemu-mips provided by the  same package work for you if not
>> > explain in the description what your patch does.
>> > BTW: out patches live in: ../third_party/qemu/
>> >
>> > You toolchain seems to come form debian -- any chance we could
>> standardize
>> this
>> > on ubuntu, this way the arm and mips scripts would look more similar -
>> in
>>
> any
>
>> > case can you change
>> > the name of  "trusted-toolchain-creator-**mips.sh" to reflect
>> > the "release" - it seems like you are tied to karmic.
>> > Please also mention this in the description and briefly say why you
>> > could not use precise which it a LTS release hence preferable.
>> >
>> > I will change our scripts to also reflect both the arch and the release.
>> >
>> >
>> >
>> >
>> > On 2012/07/11 17:34:40, petarj wrote:
>> > > Here is a change with scripts that download, build and prepare tools
>> for
>> MIPS
>> > > architecture. The current set is dependent on QEMU 0.12.5 and the
>> change
>> > > includes a patch for it.
>> > > We do plan to switch to 1.X QEMU later.
>>
>
>
>
http://codereview.chromium.**org/10703143/<http://codereview.chromium.org/107...
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[petarj, 2012-07-20 16:03:34]

The files have been renamed to be inline with the ARM versions. Additionally,
the QEMU patch has been moved to a separate CL at:

http://codereview.chromium.org/10810038/

[petarj, 2012-08-02 22:10:51]

Any response here?

On 2012/07/20 16:03:34, petarj wrote:
> The files have been renamed to be inline with the ARM versions. Additionally,
> the QEMU patch has been moved to a separate CL at:
> 
> http://codereview.chromium.org/10810038/

[robertm, 2012-08-03 20:06:10]

a few nits below

http://codereview.chromium.org/10703143/diff/6001/tools/trusted_cross_toolcha...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

http://codereview.chromium.org/10703143/diff/6001/tools/trusted_cross_toolcha...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:20:
export TMP=$(pwd)/toolchain/tmp/crosstool-trusted
do these have to be "export"
can they be "readonly" instead

http://codereview.chromium.org/10703143/diff/6001/tools/trusted_cross_toolcha...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:141:
save=$(pwd)
use pushd/ popd

http://codereview.chromium.org/10703143/diff/6001/tools/trusted_cross_toolcha...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:177:
readonly REPO=http://ftp.debian.org/debian
REPO is very generic - can this be made more specific?

http://codereview.chromium.org/10703143/diff/6001/tools/trusted_cross_toolcha...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:235:
save=$(pwd)
use pushd / popd

http://codereview.chromium.org/10703143/diff/6001/tools/trusted_cross_toolcha...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:275:
local
download="http://download.savannah.gnu.org/releases/qemu/qemu-0.12.5.tar.gz"
make download and patch_mips32 toplevel readonlys

[petarj, 2012-08-07 17:44:10]

The code has been updated. Check the patch set #3.

[robertm, 2012-08-07 17:55:19]

LGTM

a more few nits

http://codereview.chromium.org/10703143/diff/12001/tools/trusted_cross_toolch...
File tools/trusted_cross_toolchains/qemu_tool_mips32.sh (right):

http://codereview.chromium.org/10703143/diff/12001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/qemu_tool_mips32.sh:6: # Copyright 2012, Google
Inc.
why the second copyright notice

http://codereview.chromium.org/10703143/diff/12001/tools/trusted_cross_toolch...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

http://codereview.chromium.org/10703143/diff/12001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:219:
bzcat ${TMP}/../Packages_mipsel.bz2 | egrep '^(Package:|Filename:)' >
${TMP}/../Packages_mipsel
break line before pipe

http://codereview.chromium.org/10703143/diff/12001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:221:
grep  -A 1 "${pkg}\$" ${TMP}/../Packages_mipsel | egrep -o "pool/.*" >>
${TMP_PACKAGELIST_MIPS32}
break line before pipe

[commit-bot: I haz the power, 2012-08-07 19:07:22]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/10703143/11002

[commit-bot: I haz the power, 2012-08-07 21:38:25]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2012-08-07 21:56:57]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/10703143/11002

[commit-bot: I haz the power, 2012-08-08 04:29:27]

Change committed as 9402