End-to-end browser tests for speech recognition.

chrome/browser/speech/speech_recognition_bubble_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SPEECH_SPEECH_RECOGNITION_BUBBLE_CONTROLLER_H_
 #define CHROME_BROWSER_SPEECH_SPEECH_RECOGNITION_BUBBLE_CONTROLLER_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
@@ skipping 17 matching lines @@
         int session_id, SpeechRecognitionBubble::Button button) = 0;
 
     // Invoked when the user clicks outside the speech recognition info bubble
     // causing it to close and input focus to change.
     virtual void InfoBubbleFocusChanged(int session_id) = 0;
 
    protected:
     virtual ~Delegate() {}
   };
 
+  // All methods of this delegate are called on the UI thread.
+  class DelegateForTests {

[jam, 2012/07/11 15:59:04]

I haven't seen this pattern before. it seems unfortunate to add this interface
and code just for tests. is there no other way to get at this information?

[Primiano Tucci (use gerrit), 2012/07/11 16:15:49]

Unfortunately, I have no other idea on how to check the UI behavior of the
bubble other than intercepting events from it :/
Any clues?

+   public:
+    virtual void BubbleCreated() = 0;
+    virtual void BubbleSwitchedToRecordingMode() = 0;
+    virtual void BubbleSwitchedToRecognizingMode() = 0;
+    virtual void BubbleMessageDisplayed() = 0;
+    virtual void BubbleClosed() = 0;
+  };
+
+  static void SetDelegateForTests(DelegateForTests* delegate_for_tests);
+  static SpeechRecognitionBubbleController* GetInstanceForTests();
+
   explicit SpeechRecognitionBubbleController(Delegate* delegate);
 
   // Creates and shows a new speech recognition UI bubble in warmup mode.
   void CreateBubble(int session_id,
                     int render_process_id,
                     int render_view_id,
                     const gfx::Rect& element_rect);
 
   // Indicates to the user that audio recording is in progress.
   void SetBubbleRecordingMode();
@@ skipping 50 matching lines @@
     explicit UIRequest(RequestType type_value);
     ~UIRequest();
   };
 
   virtual ~SpeechRecognitionBubbleController();
 
   void InvokeDelegateButtonClicked(SpeechRecognitionBubble::Button button);
   void InvokeDelegateFocusChanged();
   void ProcessRequestInUiThread(const UIRequest& request);
 
+  // Instance getter for simulating button presses during tests.
+  static SpeechRecognitionBubbleController* instance_for_tests_;
+
+  // Delegate for receiving events on the UI thread during tests.
+  static DelegateForTests* delegate_for_tests_;
+
   // *** The following are accessed only on the IO thread.
   Delegate* delegate_;
 
   // The session id for currently visible bubble.
   int current_bubble_session_id_;
 
   // The render process and view ids for the currently visible bubble.
   int current_bubble_render_process_id_;
   int current_bubble_render_view_id_;
 
   RequestType last_request_issued_;
 
   // *** The following are accessed only on the UI thread.
   scoped_ptr<SpeechRecognitionBubble> bubble_;
 };
 
 // This typedef is to workaround the issue with certain versions of
 // Visual Studio where it gets confused between multiple Delegate
 // classes and gives a C2500 error. (I saw this error on the try bots -
 // the workaround was not needed for my machine).
 typedef SpeechRecognitionBubbleController::Delegate
     SpeechRecognitionBubbleControllerDelegate;
 
+typedef SpeechRecognitionBubbleController::DelegateForTests
+    SpeechRecognitionBubbleControllerDelegateForTests;
+
 }  // namespace speech
 
 #endif  // CHROME_BROWSER_SPEECH_SPEECH_RECOGNITION_BUBBLE_CONTROLLER_H_