Clean up the remaining diff in content/app

Clean up the remaining diff in content/app


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146042

[Yaron, 2012-07-10 21:21:55]

http://codereview.chromium.org/10703130/diff/1/content/app/android/library_lo...
File content/app/android/library_loader_hooks.cc (right):

http://codereview.chromium.org/10703130/diff/1/content/app/android/library_lo...
content/app/android/library_loader_hooks.cc:1: 1// Copyright (c) 2012 The
Chromium Authors. All rights reserved.
Remove the "1"

http://codereview.chromium.org/10703130/diff/1/content/app/content_main_runne...
File content/app/content_main_runner.cc (right):

http://codereview.chromium.org/10703130/diff/1/content/app/content_main_runne...
content/app/content_main_runner.cc:457: // Android doesn't support this.
These three comments are covered by the block above. Please remove here and
downstream.

http://codereview.chromium.org/10703130/diff/1/content/app/content_main_runne...
content/app/content_main_runner.cc:484: // we use LazyInstances very early on
and LazyInstance requires
I think the old comment was preferred (i.e. do the same thing as above)

[michaelbai, 2012-07-10 22:02:42]

PTAL

http://codereview.chromium.org/10703130/diff/1/content/app/android/library_lo...
File content/app/android/library_loader_hooks.cc (right):

http://codereview.chromium.org/10703130/diff/1/content/app/android/library_lo...
content/app/android/library_loader_hooks.cc:1: 1// Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2012/07/10 21:21:55, Yaron wrote:
> Remove the "1"

Done.

http://codereview.chromium.org/10703130/diff/1/content/app/content_main_runne...
File content/app/content_main_runner.cc (right):

http://codereview.chromium.org/10703130/diff/1/content/app/content_main_runne...
content/app/content_main_runner.cc:457: // Android doesn't support this.
On 2012/07/10 21:21:55, Yaron wrote:
> These three comments are covered by the block above. Please remove here and
> downstream.

Done.

http://codereview.chromium.org/10703130/diff/1/content/app/content_main_runne...
content/app/content_main_runner.cc:484: // we use LazyInstances very early on
and LazyInstance requires
On 2012/07/10 21:21:55, Yaron wrote:
> I think the old comment was preferred (i.e. do the same thing as above)

Done.

[Yaron, 2012-07-10 22:11:34]

lgtm

[jam, 2012-07-10 23:52:35]

lgtm

http://codereview.chromium.org/10703130/diff/5/content/app/android/library_lo...
File content/app/android/library_loader_hooks.cc (right):

http://codereview.chromium.org/10703130/diff/5/content/app/android/library_lo...
content/app/android/library_loader_hooks.cc:91: // We need the Chrome
AtExitManager to be created at the very beginning.
nit: drop the "Chrome"

[michaelbai, 2012-07-11 00:18:09]

http://codereview.chromium.org/10703130/diff/5/content/app/android/library_lo...
File content/app/android/library_loader_hooks.cc (right):

http://codereview.chromium.org/10703130/diff/5/content/app/android/library_lo...
content/app/android/library_loader_hooks.cc:91: // We need the Chrome
AtExitManager to be created at the very beginning.
On 2012/07/10 23:52:35, John Abd-El-Malek wrote:
> nit: drop the "Chrome"

Done.

[commit-bot: I haz the power, 2012-07-11 00:18:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10703130/8001

[commit-bot: I haz the power, 2012-07-11 01:28:36]

Try job failure for 10703130-8001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-11 01:42:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10703130/12001

[commit-bot: I haz the power, 2012-07-11 03:25:48]

Change committed as 146042