Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 10703125: Fix SplitRange() logic in SourceBufferRange to transfer next buffer position appropriately (Closed)

Created:
8 years, 5 months ago by vrk (LEFT CHROMIUM)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix SplitRange() logic in SourceBufferRange to transfer next buffer position appropriately Adds logic to transfer the waiting-for-next-keyframe state to the split range if necessary. BUG=NONE TEST=media_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146274

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Rebase ToT #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -4 lines) Patch
M media/filters/source_buffer_stream.cc View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vrk (LEFT CHROMIUM)
Hey Aaron, as I was writing SourceBufferRange::ResetNextBufferPosition() in CL 10766021, I realized I handled this ...
8 years, 5 months ago (2012-07-10 19:56:33 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM https://chromiumcodereview.appspot.com/10703125/diff/1/media/filters/source_buffer_stream.cc File media/filters/source_buffer_stream.cc (right): https://chromiumcodereview.appspot.com/10703125/diff/1/media/filters/source_buffer_stream.cc#newcode828 media/filters/source_buffer_stream.cc:828: split_range->next_buffer_index_ = next_buffer_index_ - keyframe_index; DCHECK(!waiting_for_keyframe_) ?
8 years, 5 months ago (2012-07-10 20:19:32 UTC) #2
vrk (LEFT CHROMIUM)
https://chromiumcodereview.appspot.com/10703125/diff/1/media/filters/source_buffer_stream.cc File media/filters/source_buffer_stream.cc (right): https://chromiumcodereview.appspot.com/10703125/diff/1/media/filters/source_buffer_stream.cc#newcode828 media/filters/source_buffer_stream.cc:828: split_range->next_buffer_index_ = next_buffer_index_ - keyframe_index; On 2012/07/10 20:19:32, acolwell ...
8 years, 5 months ago (2012-07-10 20:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/10703125/4001
8 years, 5 months ago (2012-07-10 22:15:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/10703125/8002
8 years, 5 months ago (2012-07-12 01:36:53 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 02:38:08 UTC) #6
Change committed as 146274

Powered by Google App Engine
This is Rietveld 408576698