Issue 10703113: [android] Fixes checkperms.py error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10703113: [android] Fixes checkperms.py error. (Closed)

Created:
8 years, 5 months ago by bulach

Modified:
8 years, 5 months ago

Reviewers:
Satish, jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android] Fixes checkperms.py error. Following http://codereview.chromium.org/10693110/. A few files moved around to pylib and had their executable bits left on. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145658

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-2 lines, --2 lines)			Patch
	A	build/android/pylib/android_commands.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	A	build/android/pylib/cmd_helper.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

8 years, 5 months ago (2012-07-09 09:50:11 UTC) #2

lgtm


On Mon, Jul 9, 2012 at 11:49 AM, <bulach@chromium.org> wrote:

> Reviewers: Satish, jochen,
>
> Description:
> [android] Fixes checkperms.py error.
>
> Following
http://codereview.chromium.**org/10693110/<http://codereview.chromium.org/106...
> .
> A few files moved around to pylib and had their executable bits left on.
>
> BUG=
> TEST=
>
>
> Please review this at
http://codereview.chromium.**org/10703113/<http://codereview.chromium.org/107...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   A build/android/pylib/android_**commands.py
>   A build/android/pylib/cmd_**helper.py
>
>
> Index: build/android/pylib/android_**commands.py
> diff --git a/build/android/pylib/android_**commands.py
> b/build/android/pylib/android_**commands.py
> old mode 100755
> new mode 100644
> Index: build/android/pylib/cmd_**helper.py
> diff --git a/build/android/pylib/cmd_**helper.py
> b/build/android/pylib/cmd_**helper.py
> old mode 100755
> new mode 100644
>
>
>

Expand Messages | Collapse Messages