Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: chrome/renderer/extensions/set_icon_natives.cc

Issue 10703111: Cleanup: make ExtensionRequestSender manage its IPC responses directly, rather (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert sceopd_observer change Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/set_icon_natives.cc
diff --git a/chrome/renderer/extensions/set_icon_natives.cc b/chrome/renderer/extensions/set_icon_natives.cc
index 93213e9ae48034e149cd2203a13cf72aac91275c..bb34cf07a481b4f50cd97be3b65e9349c8c7f7d9 100644
--- a/chrome/renderer/extensions/set_icon_natives.cc
+++ b/chrome/renderer/extensions/set_icon_natives.cc
@@ -81,20 +81,15 @@ v8::Handle<v8::Value> SetIconNatives::SetIconCommon(
details->Get(v8::String::New("tabId"))->Int32Value());
}
- ListValue list_value;
- list_value.Append(dict);
+ ListValue api_args;
+ api_args.Append(dict);
std::string name = *v8::String::AsciiValue(args[0]);
- int request_id = args[2]->Int32Value();
- bool has_callback = args[3]->BooleanValue();
- bool for_io_thread = args[4]->BooleanValue();
-
- request_sender_->StartRequest(name,
- request_id,
- has_callback,
- for_io_thread,
- &list_value);
- return v8::Undefined();
+ bool has_callback = args[2]->BooleanValue();
+ bool for_io_thread = args[3]->BooleanValue();
+
+ return v8::Integer::New(request_sender_->StartRequest(
+ name, has_callback, for_io_thread, &api_args));
}
} // namespace extensions
« no previous file with comments | « chrome/renderer/extensions/send_request_natives.cc ('k') | chrome/renderer/resources/extensions/send_request.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698