Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: chrome/browser/extensions/extension_function.h

Issue 10703111: Cleanup: make ExtensionRequestSender manage its IPC responses directly, rather (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert sceopd_observer change Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_function.h
diff --git a/chrome/browser/extensions/extension_function.h b/chrome/browser/extensions/extension_function.h
index ec84ddf43e41b958ac7031ae9c7a4f6991b2e5b9..92af833cb53bdb2f86f4dac1be8cc79db35a5321 100644
--- a/chrome/browser/extensions/extension_function.h
+++ b/chrome/browser/extensions/extension_function.h
@@ -163,7 +163,6 @@ class ExtensionFunction
// Common implementation for SendResponse.
void SendResponseImpl(base::ProcessHandle process,
IPC::Sender* ipc_sender,
- int routing_id,
bool success);
// Called when we receive an extension api request that is invalid in a way
@@ -357,13 +356,10 @@ class IOThreadExtensionFunction : public ExtensionFunction {
virtual IOThreadExtensionFunction* AsIOThreadExtensionFunction() OVERRIDE;
- void set_ipc_sender(base::WeakPtr<ChromeRenderMessageFilter> ipc_sender,
- int routing_id) {
+ void set_ipc_sender(base::WeakPtr<ChromeRenderMessageFilter> ipc_sender) {
ipc_sender_ = ipc_sender;
- routing_id_ = routing_id;
}
ChromeRenderMessageFilter* ipc_sender() const { return ipc_sender_.get(); }
- int routing_id() const { return routing_id_; }
base::WeakPtr<ChromeRenderMessageFilter> ipc_sender_weak() const {
return ipc_sender_;
@@ -389,7 +385,6 @@ class IOThreadExtensionFunction : public ExtensionFunction {
private:
base::WeakPtr<ChromeRenderMessageFilter> ipc_sender_;
- int routing_id_;
scoped_refptr<const ExtensionInfoMap> extension_info_map_;
};
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698