Issue 10703109: Move the android data dir retrieving code out of DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10703109: Move the android data dir retrieving code out of DCHECK. (Closed)

Created:
8 years, 5 months ago by Satish

Modified:
8 years, 5 months ago

Reviewers:
Ted C, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move the android data dir retrieving code out of DCHECK. In CL http://codereview.chromium.org/10035034 we added this code to initialize resource pak files with the android data dir. By mistake the call to retrieve the data dir was put within a DCHECK so it doesn't get called in a release or official build. BUG=none TEST=android content shell in an official build loads the content_shell.pak file properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145654

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/shell/shell_main_delegate.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/10703109/1

8 years, 5 months ago (2012-07-09 08:04:44 UTC) #3

Change committed as 145654

Expand Messages | Collapse Messages