Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10703089: Replaced static URLRequestDataJob factory with protocol handler for Data jobs. (Closed)

Created:
8 years, 5 months ago by shalev
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Replaced static URLRequestDataJob factory with protocol handler for Data jobs. BUG=None TEST=browser_tests --single_process --gtest_filter=DownloadExtensionTest.DownloadExtensionTest_Download_DataURL Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148927

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved setting of handler to SetUpJobFactoryDefaults #

Total comments: 2

Patch Set 3 : Fixed double setting of data protocol handler in off_the_record #

Total comments: 2

Patch Set 4 : Removed Include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A net/url_request/data_protocol_handler.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A net/url_request/data_protocol_handler.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
erikwright (departed)
LGTM. http://codereview.chromium.org/10703089/diff/1/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): http://codereview.chromium.org/10703089/diff/1/chrome/browser/profiles/profile_impl_io_data.cc#newcode452 chrome/browser/profiles/profile_impl_io_data.cc:452: job_factories[i]->SetProtocolHandler(chrome::kDataScheme, Should this go in SetUpJobFactoryDefaults?
8 years, 5 months ago (2012-07-13 15:11:15 UTC) #1
shalev
http://codereview.chromium.org/10703089/diff/1/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): http://codereview.chromium.org/10703089/diff/1/chrome/browser/profiles/profile_impl_io_data.cc#newcode452 chrome/browser/profiles/profile_impl_io_data.cc:452: job_factories[i]->SetProtocolHandler(chrome::kDataScheme, On 2012/07/13 15:11:15, erikwright wrote: > Should this ...
8 years, 5 months ago (2012-07-17 19:39:48 UTC) #2
shalev
Hi Matt, Please take a look. Thanks, Shalev
8 years, 5 months ago (2012-07-17 20:42:42 UTC) #3
mmenke
LGTM
8 years, 5 months ago (2012-07-18 14:02:35 UTC) #4
willchan no longer on Chromium
http://codereview.chromium.org/10703089/diff/8001/chrome/browser/profiles/off_the_record_profile_io_data.cc File chrome/browser/profiles/off_the_record_profile_io_data.cc (right): http://codereview.chromium.org/10703089/diff/8001/chrome/browser/profiles/off_the_record_profile_io_data.cc#newcode266 chrome/browser/profiles/off_the_record_profile_io_data.cc:266: new net::DataProtocolHandler()); Shouldn't this be removed here now that ...
8 years, 5 months ago (2012-07-18 14:13:36 UTC) #5
shalev
http://codereview.chromium.org/10703089/diff/8001/chrome/browser/profiles/off_the_record_profile_io_data.cc File chrome/browser/profiles/off_the_record_profile_io_data.cc (right): http://codereview.chromium.org/10703089/diff/8001/chrome/browser/profiles/off_the_record_profile_io_data.cc#newcode266 chrome/browser/profiles/off_the_record_profile_io_data.cc:266: new net::DataProtocolHandler()); On 2012/07/18 14:13:36, willchan wrote: > Shouldn't ...
8 years, 5 months ago (2012-07-18 20:42:32 UTC) #6
shalev
Hi Will, Do you think you have time to review this before you leave? This ...
8 years, 4 months ago (2012-07-27 19:03:58 UTC) #7
willchan no longer on Chromium
http://codereview.chromium.org/10703089/diff/18001/chrome/browser/profiles/off_the_record_profile_io_data.cc File chrome/browser/profiles/off_the_record_profile_io_data.cc (right): http://codereview.chromium.org/10703089/diff/18001/chrome/browser/profiles/off_the_record_profile_io_data.cc#newcode30 chrome/browser/profiles/off_the_record_profile_io_data.cc:30: #include "net/url_request/data_protocol_handler.h" Why is this needed?
8 years, 4 months ago (2012-07-27 19:07:09 UTC) #8
willchan no longer on Chromium
pre-emptive LGTM since my only question was about reducing #include pollution if possible.
8 years, 4 months ago (2012-07-28 00:48:14 UTC) #9
shalev
http://codereview.chromium.org/10703089/diff/18001/chrome/browser/profiles/off_the_record_profile_io_data.cc File chrome/browser/profiles/off_the_record_profile_io_data.cc (right): http://codereview.chromium.org/10703089/diff/18001/chrome/browser/profiles/off_the_record_profile_io_data.cc#newcode30 chrome/browser/profiles/off_the_record_profile_io_data.cc:30: #include "net/url_request/data_protocol_handler.h" On 2012/07/27 19:07:11, willchan wrote: > Why ...
8 years, 4 months ago (2012-07-30 01:56:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shalev@chromium.org/10703089/28001
8 years, 4 months ago (2012-07-30 01:57:21 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 04:40:50 UTC) #12 
Change committed as 148927

Powered by Google App Engine
This is Rietveld 408576698