Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10703087: Ignore setters in constructors when evaluating determining firect field access (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index df545511e8a36f4336fa1ce8e3f9e2d999ecbce3..e4fa84757ff696d3499d134da6b324fc9eed0d6e 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -1858,7 +1858,9 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
buffer.add(name);
Type type = node.receiver.propagatedType.computeType(compiler);
if (type != null) {
- world.registerFieldSetter(node.element.name, type);
+ if (!work.element.isGenerativeConstructorBody()) {
+ world.registerFieldSetter(node.element.name, type);
+ }
backend.updateFieldIntegerSetters(node.element,
node.value.isInteger());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698