Add Unclean Exit Watching to CPM

chrome/browser/performance_monitor/performance_monitor.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERFORMANCE_MONITOR_PERFORMANCE_MONITOR_H_
 #define CHROME_BROWSER_PERFORMANCE_MONITOR_PERFORMANCE_MONITOR_H_
 #pragma once
 
 #include "base/callback.h"
 #include "base/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
+#include "base/timer.h"
 #include "chrome/browser/performance_monitor/database.h"
 #include "chrome/browser/performance_monitor/event.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_source.h"
 
 namespace performance_monitor {
 class Database;
 
 class PerformanceMonitor : public content::NotificationObserver {
  public:
   typedef base::Callback<void(const std::string&)> StateValueCallback;

[Yoyo Zhou, 2012/07/12 18:13:44]

Nice, this makes things more readable.

 
   // Set the path which the PerformanceMonitor should use for the database files
   // constructed. This must be done prior to the initialization of the
   // PerformanceMonitor. Returns true on success, false on failure (failure
   // likely indicates that PerformanceMonitor has already been started at the
   // time of the call).
   bool SetDatabasePath(const FilePath& path);
 
   // Returns the current PerformanceMonitor instance if one exists; otherwise
   // constructs a new PerformanceMonitor.
@@ skipping 12 matching lines @@
   // occurance.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   Database* database() { return database_.get(); }
   FilePath database_path() { return database_path_; }
 
  private:
   friend struct DefaultSingletonTraits<PerformanceMonitor>;
+  FRIEND_TEST_ALL_PREFIXES(PerformanceMonitorUncleanExitBrowserTest,
+                           OneProfileUncleanExit);
+  FRIEND_TEST_ALL_PREFIXES(PerformanceMonitorUncleanExitBrowserTest,
+                           TwoProfileUncleanExit);
 
   PerformanceMonitor();
   virtual ~PerformanceMonitor();
 
   // Perform any additional initialization which must be performed on a
   // background thread (e.g. constructing the database).
   void InitOnBackgroundThread();
 
   void FinishInit();
 
   // Register for the appropriate notifications as a NotificationObserver.
   void RegisterForNotifications();
 
+  // Checks for whether the previous profiles closed uncleanly; this method
+  // should only be called once per run in order to avoid duplication of events
+  // (exceptions made for testing purposes where we construct the environment).
+  void CheckForUncleanExits();
+
+  // Find the last active time for the profile and insert the event into the
+  // database.
+  void AddUncleanExitEvent(std::string profile_name);

[Yoyo Zhou, 2012/07/12 18:13:44]

Just noticed this one should also be a const std::string&

+
   // Gets the corresponding value of |key| from the database, and then runs
   // |callback| with that value as a parameter.
   void GetStateValueOnBackgroundThread(
       const std::string& key,
       const StateValueCallback& callback);
 
   void CheckForVersionUpdateHelper(const std::string& previous_version);
 
   // Wrapper function for inserting events into the database.
   void AddEvent(scoped_ptr<Event> event);
 
   void AddEventOnBackgroundThread(scoped_ptr<Event> event);
 
+  // Update the database record of the last time the active profiles were
+  // running; this is used in determining when an unclean exit occurred.
+  void UpdateLiveProfiles();
+  void UpdateLiveProfilesHelper(
+      scoped_ptr<std::set<std::string> > active_profiles, std::string time);
+
+  // Perform any collections that are done on a timed basis.
+  void DoTimedCollections();
+
   // The location at which the database files are stored; if empty, the database
   // will default to '<user_data_dir>/performance_monitor_dbs'.
   FilePath database_path_;
 
   scoped_ptr<Database> database_;
 
   content::NotificationRegistrar registrar_;
 
+  base::RepeatingTimer<PerformanceMonitor> timer_;
+
   DISALLOW_COPY_AND_ASSIGN(PerformanceMonitor);
 };
 
 }  // namespace performance_monitor
 
 #endif  // CHROME_BROWSER_PERFORMANCE_MONITOR_PERFORMANCE_MONITOR_H_