Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 10703075: Fix default alignment of drawn text when no alignment flags are passed. (Closed)

Created:
8 years, 5 months ago by Alexei Svitkine (slow)
Modified:
8 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, xji
Visibility:
Public.

Description

Fix default alignment of drawn text when no alignment flags are passed. This corresponds to logic in canvas_win.cc at the top of ComputeFormatFlags(). BUG=135639, 135058 TEST=Open chrome.exe --lang=he and go to the NTP. Tab title should be right aligned. In the same instance, go to www.google.com. The text "Google" should also be right aligned. There should be no changes in LTR UI. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145435

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/gfx/canvas_skia.cc View 1 chunk +8 lines, -0 lines 3 comments Download

Messages

Total messages: 12 (0 generated)
Alexei Svitkine (slow)
8 years, 5 months ago (2012-07-03 18:57:52 UTC) #1
msw
http://codereview.chromium.org/10703075/diff/3001/ui/gfx/canvas_skia.cc File ui/gfx/canvas_skia.cc (right): http://codereview.chromium.org/10703075/diff/3001/ui/gfx/canvas_skia.cc#newcode153 ui/gfx/canvas_skia.cc:153: else Make this "else if (flags & gfx::Canvas::TEXT_ALIGN_LEFT)", and ...
8 years, 5 months ago (2012-07-03 20:32:23 UTC) #2
Alexei Svitkine (slow)
http://codereview.chromium.org/10703075/diff/3001/ui/gfx/canvas_skia.cc File ui/gfx/canvas_skia.cc (right): http://codereview.chromium.org/10703075/diff/3001/ui/gfx/canvas_skia.cc#newcode153 ui/gfx/canvas_skia.cc:153: else On 2012/07/03 20:32:23, msw wrote: > Make this ...
8 years, 5 months ago (2012-07-03 20:34:46 UTC) #3
msw
LGTM http://codereview.chromium.org/10703075/diff/3001/ui/gfx/canvas_skia.cc File ui/gfx/canvas_skia.cc (right): http://codereview.chromium.org/10703075/diff/3001/ui/gfx/canvas_skia.cc#newcode153 ui/gfx/canvas_skia.cc:153: else On 2012/07/03 20:34:46, Alexei Svitkine wrote: > ...
8 years, 5 months ago (2012-07-03 21:06:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10703075/3001
8 years, 5 months ago (2012-07-03 21:06:46 UTC) #5
commit-bot: I haz the power
Try job failure for 10703075-3001 (retry) (retry) on linux_rel for step "interactive_ui_tests". It's a second ...
8 years, 5 months ago (2012-07-03 22:03:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10703075/3001
8 years, 5 months ago (2012-07-03 22:04:44 UTC) #7
commit-bot: I haz the power
Try job failure for 10703075-3001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-07-03 22:47:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10703075/3001
8 years, 5 months ago (2012-07-04 03:22:55 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 5 months ago (2012-07-04 04:48:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10703075/3001
8 years, 5 months ago (2012-07-04 04:48:24 UTC) #11
commit-bot: I haz the power
8 years, 5 months ago (2012-07-04 06:13:07 UTC) #12
Change committed as 145435

Powered by Google App Engine
This is Rietveld 408576698