Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 10703068: clang: Enable -Wunused-private-field on mac. (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

clang: Enable -Wunused-private-field on mac. linux and linux_chromeos aren't quite there yet. BUG=none TEST=none TBR=mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145302

Patch Set 1 #

Patch Set 2 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
I'll get this enabled on linux / cros too, but landing this for mac should ...
8 years, 5 months ago (2012-07-03 15:23:19 UTC) #1
Mark Mentovai
8 years, 5 months ago (2012-07-03 15:24:31 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698