Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 10703061: chrome/browser/ui: Put browser_dialogs.h into chrome namespace. (Closed)

Created:
8 years, 5 months ago by tfarina
Modified:
8 years, 5 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, oshima+watch_chromium.org, yoshiki+watch_chromium.org, jam, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, stuartmorgan+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

chrome/browser/ui: Put browser_dialogs.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -100 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/collected_cookies_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_danger_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/about_ipc_dialog.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/web_dialog_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/stubs_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/web_dialog_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/set_as_default_browser_ui.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_dialog.cc View 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
TBRing...
8 years, 5 months ago (2012-07-02 03:17:52 UTC) #1
Ben Goodger (Google)
8 years, 5 months ago (2012-07-02 18:01:34 UTC) #2
LGTM


On Sun, Jul 1, 2012 at 8:17 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> TBRing...
>
> Description:
> chrome/browser/ui: Put browser_dialogs.h into chrome namespace.
>
> BUG=133088
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10703061/<http://codereview.chromium.org/107...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/browser_about_**handler.cc
>   M chrome/browser/collected_**cookies_browsertest.cc
>   M chrome/browser/download/**download_danger_prompt.cc
>   M chrome/browser/extensions/**extension_install_ui_default.**cc
>   M chrome/browser/plugin_**observer.cc
>   M chrome/browser/printing/cloud_**print/cloud_print_setup_flow.**cc
>   M chrome/browser/printing/print_**dialog_cloud.cc
>   M chrome/browser/ui/browser.cc
>   M chrome/browser/ui/browser_**content_setting_bubble_model_**delegate.cc
>   M chrome/browser/ui/browser_**dialogs.h
>   M chrome/browser/ui/cocoa/about_**ipc_dialog.mm<http://about_ipc_dialog.mm>
>   M
chrome/browser/ui/cocoa/**content_settings/collected_**cookies_mac.mm<http://collected_cookies_mac.mm>
>   M chrome/browser/ui/cocoa/**extensions/extension_**
> installed_bubble_bridge.mm <http://extension_installed_bubble_bridge.mm>
>   M
chrome/browser/ui/cocoa/hung_**renderer_controller.mm<http://hung_renderer_controller.mm>
>   M
chrome/browser/ui/cocoa/tab_**modal_confirm_dialog_mac.mm<http://tab_modal_confirm_dialog_mac.mm>
>   M
chrome/browser/ui/cocoa/web_**dialog_window_controller.mm<http://web_dialog_window_controller.mm>
>   M chrome/browser/ui/gtk/**collected_cookies_gtk.cc
>   M chrome/browser/ui/gtk/**extensions/extension_**installed_bubble_gtk.cc
>   M chrome/browser/ui/gtk/hung_**renderer_dialog_gtk.cc
>   M chrome/browser/ui/gtk/tab_**modal_confirm_dialog_gtk.cc
>   M chrome/browser/ui/gtk/web_**dialog_gtk.cc
>   M chrome/browser/ui/views/about_**ipc_dialog.cc
>   M chrome/browser/ui/views/**collected_cookies_views.cc
>   M chrome/browser/ui/views/**extensions/extension_**installed_bubble.cc
>   M chrome/browser/ui/views/**external_tab_container_win.cc
>   M chrome/browser/ui/views/hung_**renderer_view.cc
>   M chrome/browser/ui/views/stubs_**aura.cc
>   M chrome/browser/ui/views/tab_**modal_confirm_dialog_views.cc
>   M chrome/browser/ui/views/web_**dialog_view.cc
>   M chrome/browser/ui/webui/**chromeos/mobile_setup_dialog.**cc
>   M chrome/browser/ui/webui/set_**as_default_browser_ui.cc
>   M chrome/browser/ui/webui/tab_**modal_confirm_dialog_webui.cc
>   M chrome/browser/ui/webui/task_**manager/task_manager_dialog.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698