Issue 3753. Support for @deprecated annotation

compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
index 9e78372180f002865b70903e0c4312a8f01dcea6..f7b32a95af9d7a4439a834a0bf6aa89b3bbfa055 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
@@ -2923,6 +2923,34 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
         libraryResult.getErrors(),
         errEx(TypeErrorCode.NOT_A_TYPE, 3, 1, 4));
   }
+  
+  public void test_metadata_deprecated() throws Exception {
+    AnalyzeLibraryResult libraryResult = analyzeLibrary(
+        "// filler filler filler filler filler filler filler filler filler filler",
+        "// @deprecated",
+        "ttt() {}",
+        "// @deprecated",

[Brian Wilkerson, 2012/06/29 16:17:49]

Does deprecating a class implicitly deprecate everything inside it? If so, then
the deprecated markers inside this class are not needed (although we should test
them inside a class that isn't also deprecated). If not, then I'm not sure why
the implicit constructor is deprecated.

[scheglov, 2012/06/29 20:11:57]

Constructor invocation has form: Type[.nameOfConstructor](args).
I.e. we add warning for type reference.
We could not declare local variable, for example "new
DeprecatedType().doSomething()" and in this case it still would be nice to show
that "DeprecatedType" is deprecated.

I don't think that we should propagate deprecation flag to the type members.
It would show to much deprecation warnings.
Just one warning at the place of declaration (or creation) is enough.
Of course, if you want specify type annotation, you will not see it.
But if you don't specify types, you probably care even less about deprecation.

[Brian Wilkerson, 2012/06/29 20:20:28]

OK. I understand the reasoning behind the behavior.
I agree. I'm fine with it now that I understand the reasoning.

+        "class A {",
+        "  // @deprecated",
+        "  var fff;",
+        "  // @deprecated",
+        "  mmm() {}",
+        "}",
+        "main() {",
+        "  ttt();",
+        "  A a = new A();",
+        "  a.fff = 0;",
+        "  a.mmm();",
+        "}",
+        "");
+    assertErrors(
+        libraryResult.getErrors(),
+        errEx(TypeErrorCode.DEPRECATED_ELEMENT, 13, 3, 1),
+        errEx(TypeErrorCode.DEPRECATED_ELEMENT, 13, 13, 1),
+        errEx(TypeErrorCode.DEPRECATED_ELEMENT, 12, 3, 3),
+        errEx(TypeErrorCode.DEPRECATED_ELEMENT, 14, 5, 3),
+        errEx(TypeErrorCode.DEPRECATED_ELEMENT, 15, 5, 3));
+  }
 
   private static <T extends DartNode> T findNode(
       AnalyzeLibraryResult libraryResult,