Issue 3753. Support for @deprecated annotation

compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.type;
 
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Joiner;
 import com.google.common.base.Objects;
 import com.google.common.collect.ArrayListMultimap;
@@ skipping 1206 matching lines @@
       }
       DartNode target = node.getTarget();
       Type receiver = nonVoidTypeOf(target);
       Member member = lookupMember(receiver, name, nameNode);
       if (member != null) {
         Element methodElement = member.getElement();
         node.setElement(methodElement);
         if (nameNode != null) {
           nameNode.setElement(methodElement);
         }
+        // @deprecated
+        if (methodElement != null && methodElement.getMetadata().isDeprecated()) {

[Brian Wilkerson, 2012/06/29 16:17:49]

This needs to be copied into visitBinaryExpression,
visitFunctionObjectInvocation, visitRedirectConstructorInvocation,
visitSuperConstructorInvocation, and visitUnaryExpression. It might be possible
to move it into checkInvocation and cover all of those cases in one place, but I
haven't looked that deeply.

[scheglov, 2012/06/29 20:11:57]

Done.

+          onError(nameNode, TypeErrorCode.DEPRECATED_ELEMENT, name);
+        }
       }
       FunctionType methodType = getMethodType(receiver, member, name, nameNode);
       return checkInvocation(node, nameNode, name, methodType);
     }
 
     @Override
     public Type visitSuperConstructorInvocation(DartSuperConstructorInvocation node) {
       return checkConstructorForwarding(node, node.getElement());
     }
 
@@ skipping 710 matching lines @@
         return dynamicType;
       }
       element = member.getElement();
       node.setElement(element);
       Modifiers modifiers = element.getModifiers();
       if (modifiers.isStatic()) {
         return typeError(node.getName(),
                          TypeErrorCode.STATIC_MEMBER_ACCESSED_THROUGH_INSTANCE,
                          name, element.getName());
       }
+      // @deprecated
+      if (element != null && element.getMetadata().isDeprecated()) {
+        onError(node.getName(), TypeErrorCode.DEPRECATED_ELEMENT, name);
+      }
+      // analyze Element
       switch (element.getKind()) {
         case DYNAMIC:
           return dynamicType;
         case CONSTRUCTOR:
           return typeError(node.getName(), TypeErrorCode.MEMBER_IS_A_CONSTRUCTOR,
                            name, element.getName());
 
         case METHOD:
           return member.getType();
 
@@ skipping 240 matching lines @@
       // special support for "assert"
       if (Elements.isArtificialAssertMethod(element)) {
         if (node.getArguments().size() == 1) {
           DartExpression condition = node.getArguments().get(0);
           checkAssertCondition(condition);
         } else {
           onError(node, TypeErrorCode.ASSERT_NUMBER_ARGUMENTS);
         }
         return voidType;
       }
+      // @deprecated
+      if (element != null && element.getMetadata().isDeprecated()) {
+        onError(target, TypeErrorCode.DEPRECATED_ELEMENT, name);
+      }
       // normal invocation
       Type type;
       switch (ElementKind.of(element)) {
         case FIELD:
         case METHOD:
           type = typeAsMemberOf(element, currentClass);
           break;
         case NONE:
           if (!target.isResolutionAlreadyReportedThatTheMethodCouldNotBeFound()) {
             onError(target, TypeErrorCode.INTERFACE_HAS_NO_METHOD_NAMED, currentClass, target);
@@ skipping 606 matching lines @@
         for (VariableElement v : parameters) {
           if (v.isNamed()) {
             named.add(v);
           }
         }
         return named;
       }
     }
   }
 }