Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 10703027: Workaround Skia clipping bug in print_web_view_helper.cc. (Closed)

Created:
8 years, 5 months ago by Alexei Svitkine (slow)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Workaround Skia clipping bug in print_web_view_helper.cc. BUG=133548 TEST=Test that text isn't clipped incorrectly when enabling RenderTextMac code in print_web_view_helper.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144795

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/renderer/print_web_view_helper.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
8 years, 5 months ago (2012-06-28 15:53:53 UTC) #1
kmadhusu
Since you had initial discussions about the workaround with vandebo@, I am deferring this review ...
8 years, 5 months ago (2012-06-28 17:56:31 UTC) #2
vandebo (ex-Chrome)
LGTM w/ nit http://codereview.chromium.org/10703027/diff/1/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): http://codereview.chromium.org/10703027/diff/1/chrome/renderer/print_web_view_helper.cc#newcode432 chrome/renderer/print_web_view_helper.cc:432: // Remove it when the underlying ...
8 years, 5 months ago (2012-06-28 18:07:27 UTC) #3
Alexei Svitkine (slow)
http://codereview.chromium.org/10703027/diff/1/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): http://codereview.chromium.org/10703027/diff/1/chrome/renderer/print_web_view_helper.cc#newcode432 chrome/renderer/print_web_view_helper.cc:432: // Remove it when the underlying Skia bug has ...
8 years, 5 months ago (2012-06-28 18:29:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10703027/1002
8 years, 5 months ago (2012-06-28 18:29:24 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-28 21:11:06 UTC) #6
Change committed as 144795

Powered by Google App Engine
This is Rietveld 408576698