Issue 10703005: Allow inlining of functions containing RegExp literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10703005: Allow inlining of functions containing RegExp literals. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger

Modified:
8 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Allow inlining of functions containing RegExp literals. R=yangguo@chromium.org BUG=v8:1322 TEST=mjsunit/compiler/inline-literals Committed: https://code.google.com/p/v8/source/detail?r=11940

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -21 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/ast.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/objects-printer.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	test/mjsunit/compiler/inline-literals.js	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Yang

8 years, 5 months ago (2012-06-27 11:38:24 UTC) #2

On 2012/06/27 11:21:32, Michael Starzinger wrote:

LGTM.

Bonus point if inlining is actually asserted in the test.