Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 10703005: Allow inlining of functions containing RegExp literals. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger
Modified:
8 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Allow inlining of functions containing RegExp literals. R=yangguo@chromium.org BUG=v8:1322 TEST=mjsunit/compiler/inline-literals Committed: https://code.google.com/p/v8/source/detail?r=11940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -21 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/ast.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M test/mjsunit/compiler/inline-literals.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 5 months ago (2012-06-27 11:21:32 UTC) #1
Yang
8 years, 5 months ago (2012-06-27 11:38:24 UTC) #2
On 2012/06/27 11:21:32, Michael Starzinger wrote:

LGTM.

Bonus point if inlining is actually asserted in the test.

Powered by Google App Engine
This is Rietveld 408576698