Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10703003: Don't use the system versions of sqlite, libjpeg, expat and stlport on Android (Closed)

Created:
8 years, 5 months ago by Steve Block
Modified:
8 years, 5 months ago
Reviewers:
bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Don't use the system versions of sqlite, libjpeg, expat and stlport on Android These options currently don't work, so we shouldn't use them, irrespective of the value of android_build_type. We'll address each option individually in the future. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Steve Block
8 years, 5 months ago (2012-06-27 10:32:34 UTC) #1
bulach
lgtm but how about s/Never use/Don't use/ ? the "never" seems too assertive and doesn't ...
8 years, 5 months ago (2012-06-27 10:37:48 UTC) #2
Steve Block
> the "never" seems too assertive and doesn't really match the rest of the patch ...
8 years, 5 months ago (2012-06-27 10:39:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/10703003/1
8 years, 5 months ago (2012-06-27 11:37:09 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 12:56:33 UTC) #5
Change committed as 144445

Powered by Google App Engine
This is Rietveld 408576698