Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 10702203: Modify sql unittests to pass on iOS. (Closed)

Created:
8 years, 5 months ago by rohitrao (ping after 24h)
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Modify sql unittests to pass on iOS. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146604

Patch Set 1 #

Patch Set 2 : Double it! #

Patch Set 3 : Typo. #

Patch Set 4 : Style. #

Patch Set 5 : I'm burning through patchsets like nobody's business. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M sql/connection_unittest.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M sql/run_all_unittests.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M sql/sqlite_features_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rohitrao (ping after 24h)
Scott, We used to have kPageSize #ifdefed differently for iOS, but I think it'll be ...
8 years, 5 months ago (2012-07-13 13:49:21 UTC) #1
Scott Hess - ex-Googler
On 2012/07/13 13:49:21, rohitrao wrote: > We used to have kPageSize #ifdefed differently for iOS, ...
8 years, 5 months ago (2012-07-13 16:46:08 UTC) #2
rohitrao (ping after 24h)
> The point of that code was to make certain that the new version of ...
8 years, 5 months ago (2012-07-13 17:02:32 UTC) #3
Scott Hess - ex-Googler
thanks, LGTM.
8 years, 5 months ago (2012-07-13 17:16:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10702203/6005
8 years, 5 months ago (2012-07-13 17:32:47 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-13 18:55:23 UTC) #6
Change committed as 146604

Powered by Google App Engine
This is Rietveld 408576698