Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: lib/mirrors/mirrors.dart

Issue 10702186: Replaced simpleValue with more general reflectee. hasSimpleValue is retained internally for the sak… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/mirrors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/mirrors/mirrors.dart
===================================================================
--- lib/mirrors/mirrors.dart (revision 9607)
+++ lib/mirrors/mirrors.dart (working copy)
@@ -107,24 +107,27 @@
InterfaceMirror getClass();
/**
- * Does [simpleValue] contain the value of the reflectee?
- */
- bool hasSimpleValue;
-
- /**
- * If the [InstanceMirror] refers to a simple value, we provide
- * access to the actual value here.
+ * Does [reflectee] contain the instance reflected by this mirror? This will
+ * always be true in the local case (reflecting instances in the same
+ * isolate), but only true in the remote case if this mirror reflects a
+ * simple value.
*
* A value is simple if one of the following holds:
* - the value is null
* - the value is of type [num]
* - the value is of type [bool]
* - the value is of type [String]
+ */
+ final bool hasReflectee;
+
+ /**
+ * If the [InstanceMirror] reflects an instance it is meaningful to have a
+ * local reference to, we provide access to the actual instance here.
*
- * If you access [simpleValue] when [hasSimpleValue] is false an
+ * If you access [reflectee] when [hasReflectee] is false, an
* exception is thrown.
*/
- final simpleValue;
+ final reflectee;
}
/**
« no previous file with comments | « no previous file | runtime/lib/mirrors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698