Add counters that automatically track object sizes and counts.

Add counters that automatically track object sizes and counts.

Committed: https://code.google.com/p/v8/source/detail?r=12082

[danno, 2012-07-12 14:45:34]

PTAL

[Michael Starzinger, 2012-07-12 20:12:25]

One real comment in heap.cc, the rest are just nits.

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/d8.cc#newcode1307
src/d8.cc:1307: "Value       |\n");
Ueber-Nit: Can we have a space in front of "Value"?

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/heap.cc#newcode...
src/heap.cc:7233: memset(object_sizes_, 0, sizeof(object_counts_));
Better use sizeof(object_sizes_) here.

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/heap.cc#newcode...
src/heap.cc:7244: counters->count_of_##name()->Increment(object_counts_[name]);
\
Is there a particular reason we cannot use counter->Set() here? That would
obsolete the last_time_stats tables completely.

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/mark-compact.cc...
src/mark-compact.cc:948: class IterateAndCountBody {
Can we call this class "ObjectStatsTracker" or "ObjectStatsCallthrough" or
something like that?

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/mark-compact.cc...
src/mark-compact.cc:1028: // Copy the table visitor table to make call-through
possible.
Drop the first "table".

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/v8-counters.h
File src/v8-counters.h (right):

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/v8-counters.h#n...
src/v8-counters.h:1: // Copyright 2011 the V8 project authors. All rights
reserved.
2012

https://chromiumcodereview.appspot.com/10702168/diff/4001/src/v8-counters.h#n...
src/v8-counters.h:34: #include "objects.h"
Is it possible to alpha-sort these includes or does that cause include
conflicts?

[danno, 2012-07-12 21:18:16]

Please take another look

http://codereview.chromium.org/10702168/diff/4001/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/10702168/diff/4001/src/d8.cc#newcode1307
src/d8.cc:1307: "Value       |\n");
On 2012/07/12 20:12:26, Michael Starzinger wrote:
> Ueber-Nit: Can we have a space in front of "Value"?

Done.

http://codereview.chromium.org/10702168/diff/4001/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/10702168/diff/4001/src/heap.cc#newcode7233
src/heap.cc:7233: memset(object_sizes_, 0, sizeof(object_counts_));
On 2012/07/12 20:12:26, Michael Starzinger wrote:
> Better use sizeof(object_sizes_) here.

Done.

http://codereview.chromium.org/10702168/diff/4001/src/heap.cc#newcode7244
src/heap.cc:7244: counters->count_of_##name()->Increment(object_counts_[name]);
\
Yes, the reason is that you can have multiple isolates, they all have a heap and
we want the stats to track the usage of all of the isolates. Since there is no
way to track the stats separately per isolate, I have to compute the delta.
Technically, there should be a mutex, which I'll add.
On 2012/07/12 20:12:26, Michael Starzinger wrote:
> Is there a particular reason we cannot use counter->Set() here? That would
> obsolete the last_time_stats tables completely.

http://codereview.chromium.org/10702168/diff/4001/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/10702168/diff/4001/src/mark-compact.cc#newcode948
src/mark-compact.cc:948: class IterateAndCountBody {
On 2012/07/12 20:12:26, Michael Starzinger wrote:
> Can we call this class "ObjectStatsTracker" or "ObjectStatsCallthrough" or
> something like that?

Done.

http://codereview.chromium.org/10702168/diff/4001/src/mark-compact.cc#newcode...
src/mark-compact.cc:1028: // Copy the table visitor table to make call-through
possible.
On 2012/07/12 20:12:26, Michael Starzinger wrote:
> Drop the first "table".

Done.

http://codereview.chromium.org/10702168/diff/4001/src/v8-counters.h
File src/v8-counters.h (right):

http://codereview.chromium.org/10702168/diff/4001/src/v8-counters.h#newcode1
src/v8-counters.h:1: // Copyright 2011 the V8 project authors. All rights
reserved.
On 2012/07/12 20:12:26, Michael Starzinger wrote:
> 2012

Done.

http://codereview.chromium.org/10702168/diff/4001/src/v8-counters.h#newcode34
src/v8-counters.h:34: #include "objects.h"
On 2012/07/12 20:12:26, Michael Starzinger wrote:
> Is it possible to alpha-sort these includes or does that cause include
> conflicts?

Done.

[Michael Starzinger, 2012-07-13 09:22:46]

LGTM.