Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 10702164: Perform HasFastProperties check on prototypes when computing call targets in Crankshaft, part 2. (Closed)

Created:
8 years, 5 months ago by Sven Panne
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Perform HasFastProperties check on prototypes when computing call targets in Crankshaft, part 2. The previous fix was for "real" calls, this one is for getters. It is a bit unfortunate that this has to be fixed twice: We should really break up Call::ComputeTarget into a predicate and 1 or 2 getters, so code can be reused. The regression test has been modified a bit to make things more uniform. Committed: https://code.google.com/p/v8/source/detail?r=12053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M src/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-125148.js View 1 chunk +33 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 5 months ago (2012-07-12 08:06:24 UTC) #1
Jakob Kummerow
8 years, 5 months ago (2012-07-12 09:29:47 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698