add sd card when creating avd and wait for it ready before pushing data into it

as we will use sdcard to store test data, so add sd card when creating avd. 

And when testing with emulator, sometimes the test broken due to push failed because /sdcard/ is not ready. 

Adding WaitForSdCardReady to make the test more reliable. 

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146311

[bulach, 2012-07-12 07:39:10]

lgtm, thanks!

just one question on the condition for waiting the sdcard below:

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
File build/android/pylib/android_commands.py (right):

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:322: def WaitForSdCardReady(self,
timeout_time=20):
nit: please, avoid using default params... it's a real pain to maintain such
functions :)

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:323: """Wait for the SD card ready
before pushing data into it"""
nit: end this sentence with a period.

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:324: logging.info("Waiting for SD card
ready...")
nit: use single quotes here.

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:328: while not sdcard_ready and
(attempts*wait_period) < timeout_time:
nit: spaces around *, and I think the parenthesis aren't necessary..

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:329: output = self.RunShellCommand("ls
/sdcard/")
nit: single quote.

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:330: if len(output) > 0:
is this condition right? I think ls nonexistingdir will output something like
"foobar: No such file or directory"..

[Wei James(wistoch), 2012-07-12 08:03:32]

bulach, thanks for the comments. 

all issues fixed or addressed. please help to review. thanks

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
File build/android/pylib/android_commands.py (right):

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:322: def WaitForSdCardReady(self,
timeout_time=20):
On 2012/07/12 07:39:10, bulach wrote:
> nit: please, avoid using default params... it's a real pain to maintain such
> functions :)
fixed. thanks

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:323: """Wait for the SD card ready
before pushing data into it"""
On 2012/07/12 07:39:10, bulach wrote:
> nit: end this sentence with a period.

fixed. thanks

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:324: logging.info("Waiting for SD card
ready...")
On 2012/07/12 07:39:10, bulach wrote:
> nit: use single quotes here.
fixed. thanks

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:328: while not sdcard_ready and
(attempts*wait_period) < timeout_time:
On 2012/07/12 07:39:10, bulach wrote:
> nit: spaces around *, and I think the parenthesis aren't necessary..
fixed. thanks

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:329: output = self.RunShellCommand("ls
/sdcard/")
On 2012/07/12 07:39:10, bulach wrote:
> nit: single quote.

fixed. thanks

http://codereview.chromium.org/10702162/diff/3001/build/android/pylib/android...
build/android/pylib/android_commands.py:330: if len(output) > 0:
On 2012/07/12 07:39:10, bulach wrote:
> is this condition right? I think ls nonexistingdir will output something like
> "foobar: No such file or directory"..

ths /sdcard/ is a symbolic link to /mnt/sdcard and it is there even sd card is
not ready. 

I checked the return value of RunShellCommand('ls /sdcard/'), as RunShellCommand
will splitlines() for the result value, it will return an array of strings. if
the sdcard is not ready, it is an empty array and len() return 0.

[bulach, 2012-07-12 08:13:32]

lgtm, thanks for the clarification! just a tiny nit below:

http://codereview.chromium.org/10702162/diff/9001/build/android/pylib/android...
File build/android/pylib/android_commands.py (right):

http://codereview.chromium.org/10702162/diff/9001/build/android/pylib/android...
build/android/pylib/android_commands.py:337: "SD card not ready after %s
seconds" %timeout_time)
nit: single quote, and space after the second %, as in: % timeout_time

[Wei James(wistoch), 2012-07-12 08:16:37]

http://codereview.chromium.org/10702162/diff/9001/build/android/pylib/android...
File build/android/pylib/android_commands.py (right):

http://codereview.chromium.org/10702162/diff/9001/build/android/pylib/android...
build/android/pylib/android_commands.py:337: "SD card not ready after %s
seconds" %timeout_time)
On 2012/07/12 08:13:32, bulach wrote:
> nit: single quote, and space after the second %, as in: % timeout_time

fixed. thanks

[commit-bot: I haz the power, 2012-07-12 08:37:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/james.wei@intel.com/10702162/4

[commit-bot: I haz the power, 2012-07-12 10:52:56]

Change committed as 146311