gdata: Fix weird code in GDataCache::CacheEntry::Set* functions.

chrome/browser/chromeos/gdata/gdata_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CACHE_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CACHE_H_
 
 #include <map>
 #include <string>
 
@@ skipping 127 matching lines @@
     bool IsDirty() const { return cache_state & CACHE_STATE_DIRTY; }
 
     // Returns true if the file is a mounted archive file.
     bool IsMounted() const { return cache_state & CACHE_STATE_MOUNTED; }
 
     // Returns true if the file is in the persistent directory.
     bool IsPersistent() const { return cache_state & CACHE_STATE_PERSISTENT; }
 
     // Setters for the states describe above.
     void SetPresent(bool value) {
-      cache_state = (value ? cache_state |= CACHE_STATE_PRESENT :
-                     cache_state &= ~CACHE_STATE_PRESENT);
+      if (value)
+        cache_state |= CACHE_STATE_PRESENT;
+      else
+        cache_state &= ~CACHE_STATE_PRESENT;
     }
     void SetPinned(bool value) {
-      cache_state = (value ? cache_state |= CACHE_STATE_PINNED :
-                     cache_state &= ~CACHE_STATE_PINNED);
+      if (value)
+        cache_state |= CACHE_STATE_PINNED;
+      else
+        cache_state &= ~CACHE_STATE_PINNED;
     }
     void SetDirty(bool value) {
-      cache_state = (value ? cache_state |= CACHE_STATE_DIRTY :
-                     cache_state &= ~CACHE_STATE_DIRTY);
+      if (value)
+        cache_state |= CACHE_STATE_DIRTY;
+      else
+        cache_state &= ~CACHE_STATE_DIRTY;
     }
     void SetMounted(bool value) {
-      cache_state = (value ? cache_state |= CACHE_STATE_MOUNTED :
-                     cache_state &= ~CACHE_STATE_MOUNTED);
+      if (value)
+        cache_state |= CACHE_STATE_MOUNTED;
+      else
+        cache_state &= ~CACHE_STATE_MOUNTED;
     }
     void SetPersistent(bool value) {
-      cache_state = (value ? cache_state |= CACHE_STATE_PERSISTENT :
-                     cache_state &= ~CACHE_STATE_PERSISTENT);
+      if (value)
+        cache_state |= CACHE_STATE_PERSISTENT;
+      else
+        cache_state &= ~CACHE_STATE_PERSISTENT;
     }
 
     // Returns the type of the sub directory where the cache file is stored.
     CacheSubDirectoryType GetSubDirectoryType() const {
       return IsPersistent() ? CACHE_TYPE_PERSISTENT : CACHE_TYPE_TMP;
     }
 
     // For debugging purposes.
     std::string ToString() const;
 
@@ skipping 334 matching lines @@
 };
 
 // Sets the free disk space getter for testing.
 // The existing getter is deleted.
 void SetFreeDiskSpaceGetterForTesting(
     FreeDiskSpaceGetterInterface* getter);
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CACHE_H_