Issue 10702151: Revert 146162 - Move Rename functionality from DownloadFileManager to DownloadFileImple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702151: Revert 146162 - Move Rename functionality from DownloadFileManager to DownloadFileImple. (Closed)

Created:
8 years, 5 months ago by Randy Smith (Not in Mondays)

Modified:
8 years, 5 months ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, rginda+watch_chromium.org, jam, rdsmith+dwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 146162 - Move Rename functionality from DownloadFileManager to DownloadFileImple. BUG=123998 R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689093 TBR=rdsmith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146177

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+190 lines, -332 lines)			Patch
M	content/browser/download/download_file.h	View	3 chunks	+3 lines, -16 lines	0 comments	Download
M	content/browser/download/download_file_impl.h	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	content/browser/download/download_file_impl.cc	View	3 chunks	+7 lines, -39 lines	0 comments	Download
M	content/browser/download/download_file_manager.h	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	content/browser/download/download_file_manager.cc	View	1 chunk	+33 lines, -5 lines	0 comments	Download
M	content/browser/download/download_file_manager_unittest.cc	View	8 chunks	+96 lines, -24 lines	0 comments	Download
M	content/browser/download/download_file_unittest.cc	View	17 chunks	+11 lines, -173 lines	0 comments	Download
M	content/browser/download/download_item_impl.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/browser/download/download_item_impl.cc	View	4 chunks	+6 lines, -23 lines	0 comments	Download
M	content/browser/download/download_item_impl_unittest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	content/browser/download/download_manager_impl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/browser/download/download_manager_impl_unittest.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	content/browser/download/mock_download_file.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/public/browser/download_manager.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/test/mock_download_manager.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/test/test_file_error_injector.cc	View	5 chunks	+8 lines, -30 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages