Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 10702142: Use common stack trace code in Android port (Closed)

Created:
8 years, 5 months ago by Sami
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use common stack trace code in Android port StackTrace has a common implementation (stack_trace.cc) as well as platform specific ones (e.g, stack_strace_android.cc). This change makes the Android port also use the common part instead of duplicating it. This also fixes a Clang compilation failure due to the unused private member variables. Change-Id: I6ebb4815097b587cb4c6c639e5893f7759a3ff79 Reviewed-on: https://gerrit-int.chromium.org/21399 Reviewed-by: Marcus Bulach <bulach@google.com>; Tested-by: Sami Kyostila <skyostil@google.com>; BUG= TEST=Build with clang and -Wunused-private-field Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/debug/stack_trace_android.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sami
8 years, 5 months ago (2012-07-11 11:35:03 UTC) #1
willchan no longer on Chromium
lgtm
8 years, 5 months ago (2012-07-18 19:25:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/10702142/1
8 years, 5 months ago (2012-07-19 09:13:49 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 10:49:20 UTC) #4
Change committed as 147424

Powered by Google App Engine
This is Rietveld 408576698