Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: chrome/browser/extensions/api/serial/serial_api.cc

Issue 10702138: Instrument serial API code to make testing easier. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/serial/serial_api.cc
diff --git a/chrome/browser/extensions/api/serial/serial_api.cc b/chrome/browser/extensions/api/serial/serial_api.cc
index 940ec5ed859c1eac3bc0506827afa16f24d2afc1..77d4c51b61b8c36a1e4e69ed5ced204694b0b0c3 100644
--- a/chrome/browser/extensions/api/serial/serial_api.cc
+++ b/chrome/browser/extensions/api/serial/serial_api.cc
@@ -88,8 +88,8 @@ void SerialOpenFunction::Work() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
const SerialPortEnumerator::StringSet name_set(
SerialPortEnumerator::GenerateValidSerialPortNames());
- if (SerialPortEnumerator::DoesPortExist(name_set, params_->port)) {
- SerialConnection* serial_connection = new SerialConnection(
+ if (DoesPortExist(params_->port)) {
+ SerialConnection* serial_connection = CreateSerialConnection(
params_->port,
bitrate_,
event_notifier_);
@@ -116,6 +116,19 @@ void SerialOpenFunction::Work() {
}
}
+SerialConnection* SerialOpenFunction::CreateSerialConnection(
+ const std::string& port,
+ int bitrate,
+ APIResourceEventNotifier* event_notifier) {
+ return new SerialConnection(port, bitrate, event_notifier);
+}
+
+bool SerialOpenFunction::DoesPortExist(const std::string& port) {
+ const SerialPortEnumerator::StringSet name_set(
+ SerialPortEnumerator::GenerateValidSerialPortNames());
+ return SerialPortEnumerator::DoesPortExist(name_set, params_->port);
+}
+
bool SerialOpenFunction::Respond() {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698