Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10702136: Support high dpi in menu scroll arrow, submenu arrow and drag_utils. (Closed)

Created:
8 years, 5 months ago by oshima
Modified:
8 years, 5 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Support high dpi in menu scroll arrow, submenu arrow and drag_utils. Created CanvasImageSource utility class to simplify the image creating using canvas. BUG=122992 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146290

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : win build fix (export) #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : sort includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -32 lines) Patch
A ui/gfx/image/canvas_image_source.h View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A ui/gfx/image/canvas_image_source.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M ui/gfx/image/image_skia_source.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ui/ui.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_image_util.cc View 5 chunks +41 lines, -26 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 1 2 3 4 2 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
LGTM. I think this is useful as it makes things semantically easier to understand. http://codereview.chromium.org/10702136/diff/1/ui/gfx/image/canvas_image_source.h ...
8 years, 5 months ago (2012-07-10 21:44:29 UTC) #1
oshima
ben -> OWNERS
8 years, 5 months ago (2012-07-10 23:33:32 UTC) #2
oshima
On 2012/07/10 23:33:32, oshima wrote: > ben -> OWNERS friendly ping
8 years, 5 months ago (2012-07-11 17:55:03 UTC) #3
Ben Goodger (Google)
lgtm http://codereview.chromium.org/10702136/diff/6002/ui/views/controls/menu/menu_scroll_view_container.cc File ui/views/controls/menu/menu_scroll_view_container.cc (right): http://codereview.chromium.org/10702136/diff/6002/ui/views/controls/menu/menu_scroll_view_container.cc#newcode23 ui/views/controls/menu/menu_scroll_view_container.cc:23: #include "third_party/skia/include/core/SkPath.h" sort with others
8 years, 5 months ago (2012-07-12 03:12:45 UTC) #4
oshima
http://codereview.chromium.org/10702136/diff/6002/ui/views/controls/menu/menu_scroll_view_container.cc File ui/views/controls/menu/menu_scroll_view_container.cc (right): http://codereview.chromium.org/10702136/diff/6002/ui/views/controls/menu/menu_scroll_view_container.cc#newcode23 ui/views/controls/menu/menu_scroll_view_container.cc:23: #include "third_party/skia/include/core/SkPath.h" On 2012/07/12 03:12:45, Ben Goodger (Google) wrote: ...
8 years, 5 months ago (2012-07-12 04:00:19 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 04:00:28 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698