Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(41)

Issue 10702135: Merge 120858 - [chromium] Separate LayerRenderer initialization from updateLayers (Closed)

Created:
8 years, 7 months ago by danakj
Modified:
8 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 120858 - [chromium] Separate LayerRenderer initialization from updateLayers https://bugs.webkit.org/show_bug.cgi?id=89525 Reviewed by Adrienne Walker. Source/WebCore: This adds an explicit call to initialize the layer renderer of a given CCLayerTreeHost instead of having it be implicit in updateLayers(). This way the proxies can control the initialization sequence more closely and do useful work between the two calls. Refactor, no change in behavior. Covered by existing tests. * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::compositeAndReadback): (WebCore::CCLayerTreeHost::initializeLayerRendererIfNeeded): (WebCore): (WebCore::CCLayerTreeHost::updateLayers): * platform/graphics/chromium/cc/CCLayerTreeHost.h: (CCLayerTreeHost): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::commitAndComposite): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::compositeAndReadback): (WebCore::CCThreadProxy::beginFrame): Source/WebKit/chromium: Update tests to call initializeLayerRendererIfNeeded() before calling updateLayers() to reflect what the proxies do. * tests/CCLayerTreeHostTest.cpp: (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): (WTF::CCLayerTreeHostTestManySurfaces::beginTest): * tests/TiledLayerChromiumTest.cpp: TBR=jamesr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp View 4 chunks +9 lines, -13 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
danakj
8 years, 7 months ago (2012-07-10 20:43:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698