Issue 10702133: gdata: Remove sub_dir_type from CacheEntry for simplicity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702133: gdata: Remove sub_dir_type from CacheEntry for simplicity (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
hshi1

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove sub_dir_type from CacheEntry for simplicity This is a reland of crrev.com/145933 which was reverted as it broke ChromiumOS (x86) build. Having this member was awkward, as it's inconsistent with other states, which are all stored in |cache_state|. BUG=136390 TEST=out/Release/unit_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145953

Patch Set 1 #

Patch Set 2 : the fix #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+223 lines, -163 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_cache.h	View		6 chunks	+30 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache.cc	View		17 chunks	+56 lines, -45 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache_metadata.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache_metadata.cc	View	1	9 chunks	+9 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc	View		10 chunks	+29 lines, -33 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache_unittest.cc	View		25 chunks	+86 lines, -50 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View		6 chunks	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

The original patch was reverted. Please see diff from the Patch Set 1

8 years, 5 months ago (2012-07-10 20:08:46 UTC) #1

lgtm

Expand Messages | Collapse Messages