Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5374)

Unified Diff: build/common.gypi

Issue 10702129: Fix use_system_stlport on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 737654ee0c8f342b8279f317a8fb9569699b2683..16dd15ab9727d428d42fb9c6f28ab849a4e1be86 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -968,8 +968,8 @@
'static_link_system_icu%': 0,
}],
],
- # TODO(steveblock): Investigate using the system versions of sqlite,
- # libjpeg and stlport.
+ # TODO(steveblock): Investigate using the system versions of sqlite and
+ # libjpeg.
# Enable to use system sqlite.
'use_system_sqlite%': 0, # '<(android_build_type)',
# Enable to use system libjpeg.
@@ -978,7 +978,7 @@
'use_system_expat%': '<(android_build_type)',
# Enable to use the system stlport, otherwise statically
# link the NDK one?
- 'use_system_stlport%': 0, # '<(android_build_type)',
+ 'use_system_stlport%': '<(android_build_type)',
# Copy it out one scope.
'android_build_type%': '<(android_build_type)',
}], # OS=="android"
@@ -2562,7 +2562,13 @@
# don't use '-isystem' because the arm-linux-androideabi-4.4.3
# toolchain (circa Gingerbread) will exhibit strange errors.
# The include ordering here is important; change with caution.
- ['use_system_stlport==0', {
+ ['use_system_stlport==1', {
+ 'cflags': [
+ # For libstdc++/include, which is used by stlport.
+ '-I<(android_src)/bionic',
+ '-I<(android_src)/external/stlport/stlport',
+ ],
+ }, { # else: use_system_stlport!=1
'cflags': [
'-I<(android_ndk_root)/sources/cxx-stl/stlport/stlport',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698