Issue 10702124: Avoid setting unused parameter in TestStreamTextureFactory::CreateStreamTexture()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702124: Avoid setting unused parameter in TestStreamTextureFactory::CreateStreamTexture() (Closed)

Created:
8 years, 5 months ago by Steve Block

Modified:
8 years, 5 months ago

Reviewers:
bulach, qinmin, brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Avoid setting unused parameter in TestStreamTextureFactory::CreateStreamTexture() This causes a compile warning. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145910

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	webkit/support/test_stream_texture_factory_android.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Steve Block

http://codereview.chromium.org/10702124/diff/1/webkit/support/test_stream_texture_factory_android.cc File webkit/support/test_stream_texture_factory_android.cc (left): http://codereview.chromium.org/10702124/diff/1/webkit/support/test_stream_texture_factory_android.cc#oldcode14 webkit/support/test_stream_texture_factory_android.cc:14: texture_id = 0; Or did you mean '*texture_id = ...

8 years, 5 months ago (2012-07-10 10:17:36 UTC) #1

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

8 years, 5 months ago (2012-07-10 14:03:03 UTC) #3

lgtm

Expand Messages | Collapse Messages