Increase worker thread stack size for AddressSanitizer. This is especially required for debug build…

Increase worker thread stack size for AddressSanitizer. This is especially required for debug builds, since ASAN uses a lot more stack and otherwise causes it to crash.

BUG=136189
TBR=jar@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145627

[jam, 2012-07-07 00:37:40]

I'm not an owner for this and i'm not familiar with posix :)

[ramant (doing other things), 2012-07-07 04:50:26]

lgtm

[commit-bot: I haz the power, 2012-07-07 05:15:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/inferno@chromium.org/10702116/1

[commit-bot: I haz the power, 2012-07-07 05:15:15]

Presubmit check for 10702116-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base/threading

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-07-07 05:15:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/inferno@chromium.org/10702116/1

[commit-bot: I haz the power, 2012-07-07 05:15:56]

Presubmit check for 10702116-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base/threading

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[jar (doing other things), 2012-07-08 05:19:11]

Judging from the pre-existing comment, this used to be setup for a 64K stack. 
... and it is slightly alarming to see it grow to 128K... but that is perchance
water under the bridge.

Can you clarify that this further increase to 256K will not be active in any
production (official) release, and is only significant to the test bots?

I was also surprised to see this has been committed... despite getting a warning
from the commit bot that you were lacking a reviewer from base.  Can you clarify
how that happened?

[jar (doing other things), 2012-07-08 05:21:36]

...and if you did TBR this bug... you should edit the description to indicate
who was expected to TBR.

Thanks in advance,

Jim

On 2012/07/08 05:19:11, jar wrote:
> Judging from the pre-existing comment, this used to be setup for a 64K stack. 
> ... and it is slightly alarming to see it grow to 128K... but that is
perchance
> water under the bridge.
> 
> Can you clarify that this further increase to 256K will not be active in any
> production (official) release, and is only significant to the test bots?
> 
> I was also surprised to see this has been committed... despite getting a
warning
> from the commit bot that you were lacking a reviewer from base.  Can you
clarify
> how that happened?

[jar (doing other things), 2012-07-08 05:30:29]

Based on offline discussion... this is debug only... and was being done to
repair busted bots.

LGTM

(but someone should be looking at why we have grown the default size to 128K
IMO).

On 2012/07/08 05:21:36, jar wrote:
> ...and if you did TBR this bug... you should edit the description to indicate
> who was expected to TBR.
> 
> Thanks in advance,
> 
> Jim
> 
> On 2012/07/08 05:19:11, jar wrote:
> > Judging from the pre-existing comment, this used to be setup for a 64K
stack. 
> > ... and it is slightly alarming to see it grow to 128K... but that is
> perchance
> > water under the bridge.
> > 
> > Can you clarify that this further increase to 256K will not be active in any
> > production (official) release, and is only significant to the test bots?
> > 
> > I was also surprised to see this has been committed... despite getting a
> warning
> > from the commit bot that you were lacking a reviewer from base.  Can you
> clarify
> > how that happened?