Serialize/deserialize lists in JS ports

client/dart.js

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Bootstrap support for Dart scripts on the page as this script.
 if (navigator.webkitStartDart) {
   if (!navigator.webkitStartDart()) {
     document.body.innerHTML = 'This build has expired.  Please download a new Dartium at http://www.dartlang.org/dartium/index.html';
   }
 } else {
@@ skipping 35 matching lines @@
 }
 
 (function() {
   function serialize(message) {
     if (message == null) {
       return null;  // Convert undefined to null.
     } else if (typeof(message) == 'string' ||
                typeof(message) == 'number' ||
                typeof(message) == 'boolean') {
       return message;
+    } else if (message instanceof Array) {
+      return [ 'list', message.length, message ];

[vsm, 2012/07/06 13:48:16]

Hmm.  The elements of message should be serialized as well.  And, the map values
as well I think.

Feel free to add a TODO if you prefer.

[sammccall, 2012/07/06 16:01:41]

Done.

     } else if (message instanceof LocalSendPortSync) {
       return [ 'sendport', 'nativejs', message.receivePort.id ];
     } else if (message instanceof DartSendPortSync) {
       return [ 'sendport', 'dart', message.receivePort.isolateId,
                message.receivePort.portId ];
     } else {
       var id = 0;
       var keys = Object.getOwnPropertyNames(message);
       var values = new Array(keys.length);
       for (var i = 0; i < keys.length; i++) {
@@ skipping 10 matching lines @@
   function deserializeHelper(x) {
     if (x == null ||
         typeof(x) == 'string' ||
         typeof(x) == 'number' ||
         typeof(x) == 'boolean') {
       return x;
     }
     switch (x[0]) {
       case 'map': return deserializeMap(x);
       case 'sendport': return deserializeSendPort(x);
+      case 'list': return x[2];

[vsm, 2012/07/06 13:48:16]

I think you need to deserialized the elements of the list (see deserializeMap
below).

[sammccall, 2012/07/06 16:01:41]

Done.

       default: throw 'unimplemented';
     }
   }
 
   function deserializeMap(x) {
     var result = { };
     var id = x[1];
     var keys = x[2];
     var values = x[3];
     for (var i = 0, length = keys.length; i < length; i++) {
@@ skipping 96 matching lines @@
     var result = null;
     var listener = function (e) {
       result = JSON.parse(e.data);
     };
     window.addEventListener(source, listener, false);
     dispatchEvent(target, [source, serialized]);
     window.removeEventListener(source, listener, false);
     return deserialize(result);
   }
 })();