Issue 10702108: Added LookupResult::GetValueFromMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702108: Added LookupResult::GetValueFromMap. (Closed)

Created:
8 years, 5 months ago by Sven Panne

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Added LookupResult::GetValueFromMap. This is needed later for crankshafted accessors and reduces copy-n-paste a bit. Committed: https://code.google.com/p/v8/source/detail?r=11996

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed formatting #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	src/property.h	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 5 months ago (2012-07-06 08:04:58 UTC) #1

LGTM with nit.

http://codereview.chromium.org/10702108/diff/1/src/property.h
File src/property.h (right):

http://codereview.chromium.org/10702108/diff/1/src/property.h#newcode342
src/property.h:342: - map->inobject_properties();
nit: when breaking lines, we usually put the operator to the end rather than the
beginning of the line.

Expand Messages | Collapse Messages