Adds browser preferences to configure first-run flow on Windows 8.

chrome/browser/ui/startup/startup_browser_creator_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/environment.h"
@@ skipping 344 matching lines @@
     // be an app tab.
     OpenApplicationTab(profile);
 
     // In case of app mode + session restore we want to focus that app.
     if (app_contents_observer.contents())
       app_contents_observer.contents()->GetView()->SetInitialFocus();
 
     if (process_startup) {
       if (browser_defaults::kOSSupportsOtherBrowsers &&
           !command_line_.HasSwitch(switches::kNoDefaultBrowserCheck)) {
-        if (!chrome::ShowAutolaunchPrompt(profile))
+        // Generally, the default browser prompt should not be shown on first
+        // run. However, when the set-as-default dialog has been suppressed, we
+        // need to allow it.
+        bool permit_prompt_on_first_run = browser_creator_ &&

[gab, 2012/07/26 17:06:18]

nit: s/bool/const bool

This make it clearer to the reader (and maybe even gets inlined in the if
statement below if the compiler is smart..?)

[Peter Kasting, 2012/07/27 18:48:06]

I'd probably just inline the whole thing into the conditional.

[motek., 2012/07/28 17:46:44]

Done.

[motek., 2012/07/28 17:46:44]

Inlined explicitly as suggested by pkasting@.

+            browser_creator_->is_set_as_default_dialog_suppressed();
+        if ((!is_first_run_ || permit_prompt_on_first_run) &&
+            !chrome::ShowAutolaunchPrompt(profile)) {

[Peter Kasting, 2012/07/27 18:48:06]

Nit: {} unnecessary

[motek., 2012/07/28 17:46:44]

But the convention in this file seems to be that if the condition is multi-line,
braces are used. Please correct me if I am wrong here...

[Peter Kasting, 2012/07/28 17:50:41]

I think you're probably right.

           chrome::ShowDefaultBrowserPrompt(profile);
+        }
       }
 #if defined(OS_MACOSX)
       // Check whether the auto-update system needs to be promoted from user
       // to system.
       KeystoneInfoBar::PromotionInfoBar(profile);
 #endif
     }
   }
 
   // If we're recording or playing back, startup the EventRecorder now
@@ skipping 528 matching lines @@
         // New:
         prefs->GetString(prefs::kHomePage),
         prefs->GetBoolean(prefs::kHomePageIsNewTabPage),
         prefs->GetBoolean(prefs::kShowHomeButton),
         // Backup:
         backup_homepage,
         backup_homepage_is_ntp,
         backup_show_home_button));
   }
 }