chrome/browser/ui/startup/default_browser_prompt.h - Issue 10702097: Adds browser preferences to configure first-run flow on Windows 8.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/startup/default_browser_prompt.h

Issue 10702097: Adds browser preferences to configure first-run flow on Windows 8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed grt@'s remarks. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/browser_ui_prefs.cc ('k') | chrome/browser/ui/startup/default_browser_prompt.cc » ('j') | chrome/browser/ui/startup/startup_browser_creator.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_PROMPT_H_	5 #ifndef CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_PROMPT_H_

6 #define CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_PROMPT_H_	6 #define CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_PROMPT_H_

7	7

8 class Profile;	8 class Profile;

9	9

10 namespace chrome {	10 namespace chrome {

11	11

12 // Shows a prompt UI to set the default browser if necessary.	12 // Shows a prompt UI to set the default browser if necessary.

13 void ShowDefaultBrowserPrompt(Profile* profile);	13 // Unless \|permit_prompt_on_first_run\| is true, this function is a noop on

	14 // first run.

	15 void ShowDefaultBrowserPrompt(Profile* profile,

	16 bool permit_prompt_on_first_run);
	sky 2012/07/25 16:09:57 Why is this taking a boolean indicating if does an Why is this taking a boolean indicating if does anything. Why can't the caller just check it? motek. 2012/07/26 12:11:04 Well, mainly because I wanted to preserve the call Show quoted text On 2012/07/25 16:09:57, sky wrote: > Why is this taking a boolean indicating if does anything. Why can't the caller > just check it? Well, mainly because I wanted to preserve the call structure. Although it does indeed make more sense not to call it in such situation, period. Changed as suggested.
14	17

15 // Shows a prompt UI to set the default browser on first run	18 // Shows a prompt UI to set the default browser on first run

16 // (if necessary and permitted).	19 // (if necessary and permitted).

17 void ShowFirstRunDefaultBrowserPrompt(Profile* profile);	20 void ShowFirstRunDefaultBrowserPrompt(Profile* profile);

18	21

19 } // namespace chrome	22 } // namespace chrome

20	23

21 #endif // CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_PROMPT_H_	24 #endif // CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_PROMPT_H_

OLD	NEW